Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F18679209
D17929.id.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D17929.id.diff
View Options
diff --git a/src/applications/differential/view/DifferentialChangesetDetailView.php b/src/applications/differential/view/DifferentialChangesetDetailView.php
--- a/src/applications/differential/view/DifferentialChangesetDetailView.php
+++ b/src/applications/differential/view/DifferentialChangesetDetailView.php
@@ -150,15 +150,31 @@
$renderer = DifferentialChangesetHTMLRenderer::getHTMLRendererByKey(
$this->getRenderer());
+ $changeset_id = $this->changeset->getID();
+
+ $vs_id = $this->getVsChangesetID();
+ if (!$vs_id) {
+ // Showing a changeset normally.
+ $left_id = $changeset_id;
+ $right_id = $changeset_id;
+ } else if ($vs_id == -1) {
+ // Showing a synthetic "deleted" changeset for a file which was
+ // removed between changes.
+ $left_id = $changeset_id;
+ $right_id = null;
+ } else {
+ // Showing a diff-of-diffs.
+ $left_id = $vs_id;
+ $right_id = $changeset_id;
+ }
+
return javelin_tag(
'div',
array(
'sigil' => 'differential-changeset',
'meta' => array(
- 'left' => nonempty(
- $this->getVsChangesetID(),
- $this->changeset->getID()),
- 'right' => $this->changeset->getID(),
+ 'left' => $left_id,
+ 'right' => $right_id,
'renderURI' => $this->getRenderURI(),
'whitespace' => $this->getWhitespace(),
'highlight' => null,
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sep 27 2025, 12:34 AM (4 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
9090576
Default Alt Text
D17929.id.diff (1 KB)
Attached To
Mode
D17929: Fix "left"/"right" changeset ID selection for synthetic deletions
Attached
Detach File
Event Timeline
Log In to Comment