Page MenuHomePhabricator

Move "hover over an inline to see the affected lines" code to the new class tree

Authored by epriestley on May 16 2017, 11:06 PM.
Referenced Files
Unknown Object (File)
Sat, Sep 17, 11:16 AM
Unknown Object (File)
Fri, Sep 2, 6:37 AM
Unknown Object (File)
Aug 9 2022, 12:47 AM
Unknown Object (File)
Aug 6 2022, 5:29 AM
Unknown Object (File)
Aug 3 2022, 10:59 PM
Unknown Object (File)
Jul 14 2022, 9:49 AM
Unknown Object (File)
Jul 2 2022, 10:55 PM
Unknown Object (File)
Jul 2 2022, 10:55 PM



Fixes T8047. Ref T12616. Fixes T9270. This moves the "hover" part of the hover/drag behavior to the new code, leaving the "drag" part for a followup change.

The new hover UI behaves properly with Quicksand (T8047) and the filetree (T9270).

Test Plan

Hovered over inlines, saw lines select properly.

Diff Detail

rP Phabricator
Lint Passed
No Test Coverage
Build Status
Buildable 17033
Build 22777: Run Core Tests
Build 22776: arc lint + arc unit

Event Timeline

Prior to this change, we also highlighted the <th /> ("Table Holumn") nodes with yellow. I think we don't really need to, although we could restore that once I finish up here. We could also make the overlay reticle bigger: I think its current size is to let you click the line numbers, but pointer-events: none does the same thing.

This revision is now accepted and ready to land.May 16 2017, 11:35 PM
This revision was automatically updated to reflect the committed changes.