Page MenuHomePhabricator

Emit resize events after making document changes during inline editing
ClosedPublic

Authored by epriestley on May 16 2017, 2:13 PM.
Tags
None
Referenced Files
F18823532: D17904.id43074.diff
Thu, Oct 23, 12:27 PM
F18783190: D17904.id43063.diff
Mon, Oct 13, 4:37 AM
F18635777: D17904.diff
Sep 17 2025, 2:46 AM
F18618998: D17904.id.diff
Sep 15 2025, 1:29 AM
F18586621: D17904.diff
Sep 11 2025, 7:13 PM
F18508805: D17904.id.diff
Sep 5 2025, 3:02 AM
F18501051: D17904.diff
Sep 4 2025, 9:31 PM
F18461381: D17904.id.diff
Sep 1 2025, 8:25 PM
Subscribers
None

Details

Summary

Ref T12634. Fixes T12633. These events allow the keyboard reticle to resize properly.

(I expect to possibly hide/disable the reticle in the future during edits, but at least make the behavior sensible for now.)

Test Plan
  • Used "n" to select a block.
  • Clicked a line number in that block to start a new inline comment.
  • Saw reticle resize properly.

Diff Detail

Repository
rP Phabricator
Branch
focus6
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16991
Build 22715: Run Core Tests
Build 22714: arc lint + arc unit