Paths

Table of Contentst

Fix breakage of Pholio
ClosedPublic
Actions

Authored by amckinley on May 15 2017, 8:25 PM.

Tags

None

Referenced Files

	F18623024: D17889.diff
	Mon, Sep 15, 1:58 PM

	F18423918: D17889.id.diff
	Aug 30 2025, 8:22 PM

	F18394827: D17889.diff
	Aug 29 2025, 10:30 AM

	Unknown Object (File)
	Apr 2 2025, 7:22 PM

	Unknown Object (File)
	Apr 1 2025, 10:37 PM

	Unknown Object (File)
	Mar 31 2025, 5:26 AM

	Unknown Object (File)
	Mar 30 2025, 10:16 PM

	Unknown Object (File)
	Mar 29 2025, 7:11 PM

View All Files

Subscribers

epriestley

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rP73ed316c5d2e: (stable) Fix breakage of Pholio
rP78544334cd69: Fix breakage of Pholio

Summary

Removal of PholioMockEditor::applyCustomInternalTransaction() in D17868 broke creation of new mocks in Pholio. Puts the empty method back until we finish migrating Pholio to modular transactions.

Test Plan

Created some mocks, observed lack of unhandled exception.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

amckinley created this revision.May 15 2017, 8:25 PM

Herald added a subscriber: epriestley. · View Herald TranscriptMay 15 2017, 8:25 PM

Harbormaster completed remote builds in B16955: Diff 43028.May 15 2017, 8:26 PM

epriestley accepted this revision.May 15 2017, 8:29 PM

This revision is now accepted and ready to land.May 15 2017, 8:29 PM

Closed by commit rP78544334cd69: Fix breakage of Pholio (authored by amckinley, committed by amckinley). · Explain WhyMay 15 2017, 8:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

pholio/

editor/

PholioMockEditor.php

6 lines

Diff 43029

View Options

src/applications/pholio/editor/PholioMockEditor.php

Fix breakage of PholioClosedPublicActions