Page MenuHomePhabricator
Differential D17868

Migrate Pholio image description and mock status to modular transactions
ClosedPublic
Actions

Authored by amckinley on May 11 2017, 12:05 AM.
Tags
None
Referenced Files
F18745689: D17868.id42974.diff
Fri, Oct 3, 8:48 AM
F18627926: D17868.diff
Tue, Sep 16, 5:08 AM
F18620510: D17868.diff
Mon, Sep 15, 5:29 AM
F18617299: D17868.id.diff
Sun, Sep 14, 8:51 PM
F18597763: D17868.id42988.diff
Sat, Sep 13, 3:36 AM
F18594373: D17868.id42989.diff
Fri, Sep 12, 5:59 PM
F18587965: D17868.id42989.diff
Thu, Sep 11, 10:55 PM
F18587964: D17868.id42989.diff
Thu, Sep 11, 10:55 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rP74d86f09023c: Migrate Pholio image description and mock status to modular transactions
Summary

Also removes more now-dead code from PholioTransaction.

Test Plan

opened and closed a bunch of mocks, edited a bunch of image descriptions

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley created this revision.May 11 2017, 12:05 AM
Herald added a subscriber: epriestley. · View Herald TranscriptMay 11 2017, 12:05 AM
Harbormaster completed remote builds in B16900: Diff 42974.May 11 2017, 12:07 AM
epriestley accepted this revision.May 11 2017, 4:33 PM
epriestley added inline comments.
src/applications/pholio/xaction/PholioImageDescriptionTransaction.php
72–73

I think this came from elsewhere, but head(array_values($x)) is equivalent to head($x).

This revision is now accepted and ready to land.May 11 2017, 4:33 PM
amckinley updated this revision to Diff 42988.May 12 2017, 11:03 PM
  • switch to just using head
Herald added a subscriber: Korvin. · View Herald TranscriptMay 12 2017, 11:03 PM
Harbormaster completed remote builds in B16912: Diff 42988.May 12 2017, 11:04 PM
Closed by commit rP74d86f09023c: Migrate Pholio image description and mock status to modular transactions (authored by amckinley, committed by amckinley). · Explain WhyMay 12 2017, 11:07 PM
This revision was automatically updated to reflect the committed changes.
amckinley mentioned this in D17889: Fix breakage of Pholio.May 15 2017, 8:25 PM
amckinley mentioned this in rP78544334cd69: Fix breakage of Pholio.May 15 2017, 8:30 PM
epriestley mentioned this in rP73ed316c5d2e: (stable) Fix breakage of Pholio.May 16 2017, 12:52 PM

Revision Contents
Changeset List

PathSize
src/
4 lines
applications/
pholio/
controller/
2 lines
2 lines
editor/
35 lines
storage/
73 lines
xaction/
PholioImageDescriptionTransaction.php
PholioImageNameTransaction.php
55 lines
10 lines
66 lines

Diff 42989

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/pholio/controller/PholioMockArchiveController.php

Loading...
View Options

src/applications/pholio/controller/PholioMockEditController.php

Loading...
View Options

src/applications/pholio/editor/PholioMockEditor.php

Loading...
View Options

src/applications/pholio/storage/PholioTransaction.php

Loading...
View Options

src/applications/pholio/xaction/PholioImageDescriptionTransaction.php

Loading...
View Options

src/applications/pholio/xaction/PholioImageNameTransaction.php

Loading...
View Options

src/applications/pholio/xaction/PholioMockStatusTransaction.php

Loading...
Phabricator · Built by Phacility