Page MenuHomePhabricator

Make getApplicationTransactionEditor() in PhabricatorApplication return an editor
ClosedPublic

Authored by epriestley on May 14 2017, 8:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 6:09 PM
Unknown Object (File)
Sun, Dec 15, 1:58 PM
Unknown Object (File)
Thu, Dec 12, 7:41 PM
Unknown Object (File)
Mon, Dec 9, 10:48 PM
Unknown Object (File)
Wed, Dec 4, 9:25 PM
Unknown Object (File)
Mon, Dec 2, 12:04 PM
Unknown Object (File)
Fri, Nov 29, 4:33 PM
Unknown Object (File)
Nov 24 2024, 9:50 PM
Subscribers
None

Details

Summary

Ref T12685. I provided this incorrect (return new rather than throw) implementation earlier; it can now be replaced with a proper implementation.

This caused application policy edits to spew this into the daemon log:

[2017-05-14 15:35:27] EXCEPTION: (Error) Call to undefined method PhutilMethodNotImplementedException::setActor() at [<phabricator>/src/applications/transactions/worker/PhabricatorApplicationTransactionPublishWorker.php:69]
Test Plan
  • Used bin/worker execute --id <id> to execute a previously-failing task.
  • Saw a feed story publish.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable