Page MenuHomePhabricator

Make getApplicationTransactionEditor() in PhabricatorApplication return an editor
ClosedPublic

Authored by epriestley on May 14 2017, 8:38 PM.
Tags
None
Referenced Files
F19469475: D17876.id42995.diff
Sun, Jan 4, 11:21 PM
F19152899: D17876.id43002.diff
Thu, Dec 11, 6:02 AM
F18918799: D17876.id.diff
Nov 9 2025, 11:14 AM
F18880143: D17876.diff
Nov 6 2025, 7:39 PM
F18866826: D17876.id43002.diff
Nov 3 2025, 7:40 PM
F18756561: D17876.diff
Oct 5 2025, 12:05 PM
F18755921: D17876.id42995.diff
Oct 5 2025, 8:14 AM
F18740251: D17876.diff
Oct 2 2025, 1:26 AM
Subscribers
None

Details

Summary

Ref T12685. I provided this incorrect (return new rather than throw) implementation earlier; it can now be replaced with a proper implementation.

This caused application policy edits to spew this into the daemon log:

[2017-05-14 15:35:27] EXCEPTION: (Error) Call to undefined method PhutilMethodNotImplementedException::setActor() at [<phabricator>/src/applications/transactions/worker/PhabricatorApplicationTransactionPublishWorker.php:69]
Test Plan
  • Used bin/worker execute --id <id> to execute a previously-failing task.
  • Saw a feed story publish.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable