Page MenuHomePhabricator

Make getApplicationTransactionEditor() in PhabricatorApplication return an editor
ClosedPublic

Authored by epriestley on May 14 2017, 8:38 PM.
Tags
None
Referenced Files
F14790756: D17876.id43002.diff
Fri, Jan 24, 8:53 PM
F14790755: D17876.id42995.diff
Fri, Jan 24, 8:53 PM
F14790754: D17876.id.diff
Fri, Jan 24, 8:53 PM
Unknown Object (File)
Thu, Jan 23, 3:23 AM
Unknown Object (File)
Sat, Jan 18, 6:09 PM
Unknown Object (File)
Sat, Jan 18, 2:36 AM
Unknown Object (File)
Sun, Jan 12, 12:16 AM
Unknown Object (File)
Mon, Jan 6, 5:17 PM
Subscribers
None

Details

Summary

Ref T12685. I provided this incorrect (return new rather than throw) implementation earlier; it can now be replaced with a proper implementation.

This caused application policy edits to spew this into the daemon log:

[2017-05-14 15:35:27] EXCEPTION: (Error) Call to undefined method PhutilMethodNotImplementedException::setActor() at [<phabricator>/src/applications/transactions/worker/PhabricatorApplicationTransactionPublishWorker.php:69]
Test Plan
  • Used bin/worker execute --id <id> to execute a previously-failing task.
  • Saw a feed story publish.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable