Page MenuHomePhabricator

Make getApplicationTransactionEditor() in PhabricatorApplication return an editor
ClosedPublic

Authored by epriestley on May 14 2017, 8:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 21, 3:22 PM
Unknown Object (File)
Tue, Feb 18, 4:30 AM
Unknown Object (File)
Mon, Feb 17, 10:00 PM
Unknown Object (File)
Mon, Feb 17, 8:39 PM
Unknown Object (File)
Thu, Feb 13, 3:03 AM
Unknown Object (File)
Sun, Feb 9, 4:01 AM
Unknown Object (File)
Sun, Feb 9, 4:01 AM
Unknown Object (File)
Sun, Feb 9, 4:01 AM
Subscribers
None

Details

Summary

Ref T12685. I provided this incorrect (return new rather than throw) implementation earlier; it can now be replaced with a proper implementation.

This caused application policy edits to spew this into the daemon log:

[2017-05-14 15:35:27] EXCEPTION: (Error) Call to undefined method PhutilMethodNotImplementedException::setActor() at [<phabricator>/src/applications/transactions/worker/PhabricatorApplicationTransactionPublishWorker.php:69]
Test Plan
  • Used bin/worker execute --id <id> to execute a previously-failing task.
  • Saw a feed story publish.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable