Page MenuHomePhabricator
Differential D17837

Don't apply patches or mark patches applied with `bin/storage upgrade --dryrun`
ClosedPublic
Actions

Authored by epriestley on May 6 2017, 2:56 AM.
Tags
None
Referenced Files
F18756428: D17837.diff
Sun, Oct 5, 11:24 AM
F18756026: D17837.id42910.diff
Sun, Oct 5, 8:47 AM
F18741359: D17837.id.diff
Thu, Oct 2, 11:57 AM
F18739259: D17837.diff
Wed, Oct 1, 8:37 PM
F18733589: D17837.id.diff
Tue, Sep 30, 10:37 PM
F18651847: D17837.diff
Sun, Sep 21, 5:41 AM
F18629263: D17837.diff
Tue, Sep 16, 8:22 AM
F18417419: D17837.id.diff
Aug 30 2025, 11:40 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12682: `storage --dry-run` actually looks rather wet when applying patches
Commits
rPb0df33e6ecd7: (stable) Don't apply patches or mark patches applied with `bin/storage upgrade…
rPbcd87e0e3f37: Don't apply patches or mark patches applied with `bin/storage upgrade --dryrun`
Summary

Fixes T12682.

Test Plan

Ran bin/storage upgrade --dryrun repeatedly with un-applied patches, saw it not apply them and not mark them applied.

Diff Detail

Repository
rP Phabricator
Branch
dry1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16836
Build 22471: Run Core Tests
Build 22470: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
infrastructure/
storage/
management/
workflow/
8 lines

Diff 42910

View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php

Loading...
Phabricator · Built by Phacility