Page MenuHomePhabricator

Add an Owners Package hovercard
ClosedPublic

Authored by chad on Apr 26 2017, 12:31 AM.

Details

Summary

Ref T12600. Basically all the property (not path) information on a hovercard for owner packages.

Test Plan

Create a package with LOTS OF RULES. Test it as open and archived states.

Diff Detail

Repository
rP Phabricator
Branch
owners-hovercar (branched from master)
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 16712
Build 22294: Run Core Tests
Build 22293: arc lint + arc unit

Event Timeline

jmeador added a subscriber: jmeador.

Really a very very beautiful hovercard. It's going to be great. Fantastic job. Really really proud of this hovercard.

This revision is now accepted and ready to land.Apr 26 2017, 6:58 AM
This revision was automatically updated to reflect the committed changes.

Couple inlines just to prove that I looked.

We could probably drop "Auto Review" and "Dominion", I think they're probably only of much use when editing/configuring the package.

src/applications/owners/engineextension/PhabricatorOwnersHovercardEngineExtension.php
49

Could use getMonogram().

src/view/phui/PHUIHovercardView.php
123–125

What about common and useful title "0"?!

src/view/phui/PHUIHovercardView.php
123–125

dammit