Fix variable name for theme_class
ClosedPublic
Actions

Authored by chad on Apr 22 2017, 2:30 PM.

Tags

None

Referenced Files

	F15421560: D17767.id42723.diff
	Sat, Mar 22, 12:49 AM

	F15418199: D17767.id42724.diff
	Thu, Mar 20, 9:30 PM

	F15408761: D17767.id.diff
	Wed, Mar 19, 1:07 AM

	F15400772: D17767.diff
	Mon, Mar 17, 1:56 PM

	F15337942: D17767.diff
	Sun, Mar 9, 8:29 AM

	Unknown Object (File)
	Feb 15 2025, 10:34 PM

	Unknown Object (File)
	Feb 8 2025, 10:10 AM

	Unknown Object (File)
	Jan 30 2025, 7:38 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley
amckinley

Maniphest Tasks

T12622: Unhandled Exception ("RuntimeException") when accessing conpherence

Commits

rP72976909b1bf: (stable) Fix variable name for theme_class
rP8d398f6f4a69: Fix variable name for theme_class

Summary

Fixes T12622. This variable is mis-named.

Test Plan

Visit a room I have not joined.

Diff Detail

Repository

rP Phabricator

Branch

theme (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16655
Build 22210: Run Core Tests
Build 22209: arc lint + arc unit

Event Timeline

chad created this revision.Apr 22 2017, 2:30 PM

Herald added a subscriber: Korvin. · View Herald TranscriptApr 22 2017, 2:30 PM

Harbormaster completed remote builds in B16655: Diff 42723.Apr 22 2017, 2:31 PM

epriestley accepted this revision.Apr 22 2017, 3:50 PM

This revision is now accepted and ready to land.Apr 22 2017, 3:50 PM

Closed by commit rP8d398f6f4a69: Fix variable name for theme_class (authored by chad, committed by chad). · Explain WhyApr 22 2017, 4:01 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

storage/

ConpherenceThread.php

2 lines

Diff 42723

View Options

src/applications/conpherence/storage/ConpherenceThread.php

Fix variable name for theme_classClosedPublicActions