Page MenuHomePhabricator
Differential D17733

Don't require a transaction to mark a participant up-to-date
ClosedPublic
Actions

Authored by epriestley on Apr 19 2017, 8:07 PM.
Tags
None
Referenced Files
F15738762: D17733.diff
Thu, May 29, 6:59 PM
Unknown Object (File)
Apr 26 2025, 6:43 PM
Unknown Object (File)
Apr 22 2025, 12:35 AM
Unknown Object (File)
Apr 21 2025, 8:29 PM
Unknown Object (File)
Apr 17 2025, 10:44 PM
Unknown Object (File)
Apr 16 2025, 10:02 PM
Unknown Object (File)
Apr 11 2025, 11:49 PM
Unknown Object (File)
Apr 9 2025, 1:01 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Commits
rPb9868f4f0578: Don't require a transaction to mark a participant up-to-date
Summary

Pathway to D17685. We no longer have "behindTransactionPHID", so we no longer need the latest transaction.

This allows some code to be removed.

Test Plan
  • Grepped for callsites to markUpToDate() and variables used in the calls.
  • Sent messages in a couple threads, viewed them, saw unread counts go away.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 19 2017, 8:07 PM
Harbormaster completed remote builds in B16584: Diff 42649.Apr 19 2017, 8:09 PM
chad accepted this revision.Apr 19 2017, 8:23 PM
This revision is now accepted and ready to land.Apr 19 2017, 8:23 PM
Closed by commit rPb9868f4f0578: Don't require a transaction to mark a participant up-to-date (authored by epriestley, committed by epriestley). · Explain WhyApr 19 2017, 9:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
conpherence/
controller/
2 lines
2 lines
33 lines
storage/
4 lines

Diff 42658

View Options

src/applications/conpherence/controller/ConpherenceColumnViewController.php

Loading...
View Options

src/applications/conpherence/controller/ConpherenceUpdateController.php

Loading...
View Options

src/applications/conpherence/controller/ConpherenceViewController.php

Loading...
View Options

src/applications/conpherence/storage/ConpherenceParticipant.php

Loading...
Phabricator · Built by Phacility