Page MenuHomePhabricator
Differential D17733

Don't require a transaction to mark a participant up-to-date
ClosedPublic
Actions

Authored by epriestley on Apr 19 2017, 8:07 PM.
Tags
None
Referenced Files
F17703963: D17733.diff
Wed, Jul 16, 2:52 AM
Unknown Object (File)
Jun 16 2025, 11:43 PM
Unknown Object (File)
Jun 16 2025, 11:43 PM
Unknown Object (File)
Jun 16 2025, 11:43 PM
Unknown Object (File)
Jun 16 2025, 9:43 PM
Unknown Object (File)
May 30 2025, 3:53 PM
Unknown Object (File)
May 29 2025, 6:59 PM
Unknown Object (File)
Apr 26 2025, 6:43 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Commits
rPb9868f4f0578: Don't require a transaction to mark a participant up-to-date
Summary

Pathway to D17685. We no longer have "behindTransactionPHID", so we no longer need the latest transaction.

This allows some code to be removed.

Test Plan
  • Grepped for callsites to markUpToDate() and variables used in the calls.
  • Sent messages in a couple threads, viewed them, saw unread counts go away.

Diff Detail

Repository
rP Phabricator
Branch
status5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16584
Build 22111: Run Core Tests
Build 22110: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 19 2017, 8:07 PM
Harbormaster completed remote builds in B16584: Diff 42649.Apr 19 2017, 8:09 PM
chad accepted this revision.Apr 19 2017, 8:23 PM
This revision is now accepted and ready to land.Apr 19 2017, 8:23 PM
Closed by commit rPb9868f4f0578: Don't require a transaction to mark a participant up-to-date (authored by epriestley, committed by epriestley). · Explain WhyApr 19 2017, 9:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
conpherence/
controller/
2 lines
3 lines
33 lines
storage/
4 lines

Diff 42649

View Options

src/applications/conpherence/controller/ConpherenceColumnViewController.php

Loading...
View Options

src/applications/conpherence/controller/ConpherenceUpdateController.php

Loading...
View Options

src/applications/conpherence/controller/ConpherenceViewController.php

Loading...
View Options

src/applications/conpherence/storage/ConpherenceParticipant.php

Loading...
Phabricator · Built by Phacility