Page MenuHomePhabricator

After Aphlict reconnects, ask the server to replay recent messages
ClosedPublic

Authored by epriestley on Apr 17 2017, 9:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 13 2024, 3:16 PM
Unknown Object (File)
Feb 3 2024, 3:35 PM
Unknown Object (File)
Jan 18 2024, 2:54 PM
Unknown Object (File)
Jan 15 2024, 2:29 PM
Unknown Object (File)
Dec 24 2023, 5:30 PM
Unknown Object (File)
Dec 22 2023, 3:21 AM
Unknown Object (File)
Dec 21 2023, 5:42 PM
Unknown Object (File)
Dec 21 2023, 5:41 PM
Subscribers
None

Details

Summary

Fixes T12563. If we've ever seen an "open", mark all future connections as reconnects. When we reconnect, replay recent history.

(Until duplicate messages (T12564) are handled better this may cause some notification duplication.)

Also emit a reconnect event (for T12566) but don't use it yet.

Test Plan

Screen Shot 2017-04-17 at 2.22.56 PM.png (916×2 px, 347 KB)

Diff Detail

Repository
rP Phabricator
Branch
aphlict6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16518
Build 22007: Run Core Tests
Build 22006: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Apr 17 2017, 10:33 PM
This revision was automatically updated to reflect the committed changes.