Page MenuHomePhabricator
Differential D17708

After Aphlict reconnects, ask the server to replay recent messages
ClosedPublic
Actions

Authored by epriestley on Apr 17 2017, 9:28 PM.
Tags
None
Referenced Files
F15442968: D17708.id42600.diff
Thu, Mar 27, 1:37 AM
F15438199: D17708.diff
Tue, Mar 25, 11:44 PM
F15426639: D17708.diff
Sun, Mar 23, 10:09 AM
F15423075: D17708.id42583.diff
Sat, Mar 22, 12:42 PM
F15418706: D17708.id42583.diff
Fri, Mar 21, 12:58 AM
F15417841: D17708.id42600.diff
Thu, Mar 20, 6:59 PM
F15403482: D17708.id.diff
Tue, Mar 18, 3:33 AM
F15400479: D17708.diff
Mon, Mar 17, 11:53 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12563: When a client reconnects to Aphlict, replay recent messages
Commits
rP02194f0fc8e9: After Aphlict reconnects, ask the server to replay recent messages
Summary

Fixes T12563. If we've ever seen an "open", mark all future connections as reconnects. When we reconnect, replay recent history.

(Until duplicate messages (T12564) are handled better this may cause some notification duplication.)

Also emit a reconnect event (for T12566) but don't use it yet.

Test Plan

Screen Shot 2017-04-17 at 2.22.56 PM.png (916×2 px, 347 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 17 2017, 9:28 PM
Harbormaster completed remote builds in B16518: Diff 42583.Apr 17 2017, 9:28 PM
Harbormaster completed remote builds in B16518: Diff 42583.
chad accepted this revision.Apr 17 2017, 10:33 PM
This revision is now accepted and ready to land.Apr 17 2017, 10:33 PM
Closed by commit rP02194f0fc8e9: After Aphlict reconnects, ask the server to replay recent messages (authored by epriestley, committed by epriestley). · Explain WhyApr 17 2017, 10:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
50 lines
src/
applications/
console/
plugin/
12 lines
support/
aphlict/
server/
5 lines
lib/
36 lines
webroot/
rsrc/
css/
aphront/
4 lines
js/
application/
aphlict/
49 lines
core/
darkconsole/
3 lines

Diff 42600

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/console/plugin/DarkConsoleRealtimePlugin.php

Loading...
View Options

support/aphlict/server/aphlict_server.js

Loading...
View Options

support/aphlict/server/lib/AphlictClientServer.js

Loading...
View Options

webroot/rsrc/css/aphront/dark-console.css

Loading...
View Options

webroot/rsrc/js/application/aphlict/Aphlict.js

Loading...
View Options

webroot/rsrc/js/core/darkconsole/behavior-dark-console.js

Loading...
Phabricator · Built by Phacility