Paths

Table of Contentst

Fix a bug where Phortune could fatal while building crumbs
ClosedPublic
Actions

Authored by epriestley on Apr 14 2017, 4:17 PM.

Tags

None

Referenced Files

	F19217669: D17689.id42543.diff
	Wed, Dec 17, 8:12 AM

	F18984906: D17689.id.diff
	Nov 17 2025, 12:48 PM

	F18854661: D17689.diff
	Nov 1 2025, 12:25 AM

	F18819253: D17689.id.diff
	Oct 22 2025, 5:16 AM

	F18807913: D17689.diff
	Oct 19 2025, 3:48 AM

	F18777059: D17689.id.diff
	Oct 11 2025, 12:45 AM

	F18777024: D17689.id42549.diff
	Oct 11 2025, 12:36 AM

	F18650577: D17689.id42549.diff
	Sep 21 2025, 1:07 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12451: Finding your subscriptions / cards on Phacility is non-obvious

Commits

rP7274e4857c23: Fix a bug where Phortune could fatal while building crumbs

Summary

Ref T12451. $this->getAccount() may not return an account.

Test Plan

Visit /phortune/X/, where X is the ID of an account you don't have permission to view.
Before patch: fatal.
After patch: normal policy exception page.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 14 2017, 4:17 PM

Harbormaster completed remote builds in B16474: Diff 42543.Apr 14 2017, 4:19 PM

thanks!

sadpanda

chad accepted this revision.Apr 14 2017, 4:27 PM

This revision is now accepted and ready to land.Apr 14 2017, 4:27 PM

Closed by commit rP7274e4857c23: Fix a bug where Phortune could fatal while building crumbs (authored by epriestley, committed by epriestley). · Explain WhyApr 14 2017, 5:22 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phortune/

controller/

account/

PhortuneAccountProfileController.php

11 lines

Diff 42549

View Options

src/applications/phortune/controller/account/PhortuneAccountProfileController.php

Fix a bug where Phortune could fatal while building crumbsClosedPublicActions