Page MenuHomePhabricator
Differential D17689

Fix a bug where Phortune could fatal while building crumbs
ClosedPublic
Actions

Authored by epriestley on Apr 14 2017, 4:17 PM.
Tags
None
Referenced Files
F17920195: D17689.id42549.diff
Wed, Jul 30, 3:27 AM
F17847065: D17689.diff
Sun, Jul 27, 5:39 AM
Unknown Object (File)
Jun 2 2025, 2:23 AM
Unknown Object (File)
May 30 2025, 4:13 AM
Unknown Object (File)
Apr 26 2025, 2:30 PM
Unknown Object (File)
Apr 25 2025, 4:03 AM
Unknown Object (File)
Apr 2 2025, 12:56 PM
Unknown Object (File)
Apr 1 2025, 9:11 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12451: Finding your subscriptions / cards on Phacility is non-obvious
Commits
rP7274e4857c23: Fix a bug where Phortune could fatal while building crumbs
Summary

Ref T12451. $this->getAccount() may not return an account.

Test Plan
  • Visit /phortune/X/, where X is the ID of an account you don't have permission to view.
  • Before patch: fatal.
  • After patch: normal policy exception page.

Diff Detail

Repository
rP Phabricator
Branch
phortune1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16474
Build 21934: Run Core Tests
Build 21933: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
phortune/
controller/
account/
11 lines

Diff 42543

View Options

src/applications/phortune/controller/account/PhortuneAccountProfileController.php

Loading...
Phabricator · Built by Phacility