Paths

Table of Contentst

Fix a bug where Phortune could fatal while building crumbs
ClosedPublic
Actions

Authored by epriestley on Apr 14 2017, 4:17 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 31, 10:56 PM

	Unknown Object (File)
	Tue, Dec 31, 7:32 PM

	Unknown Object (File)
	Sat, Dec 14, 1:43 AM

	Unknown Object (File)
	Fri, Dec 13, 7:40 PM

	Unknown Object (File)
	Thu, Dec 12, 6:05 PM

	Unknown Object (File)
	Wed, Dec 11, 4:16 AM

	Unknown Object (File)
	Wed, Dec 4, 5:20 AM

	Unknown Object (File)
	Nov 11 2024, 9:14 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12451: Finding your subscriptions / cards on Phacility is non-obvious

Commits

rP7274e4857c23: Fix a bug where Phortune could fatal while building crumbs

Summary

Ref T12451. $this->getAccount() may not return an account.

Test Plan

Visit /phortune/X/, where X is the ID of an account you don't have permission to view.
Before patch: fatal.
After patch: normal policy exception page.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 14 2017, 4:17 PM

Harbormaster completed remote builds in B16474: Diff 42543.Apr 14 2017, 4:19 PM

thanks!

sadpanda

chad accepted this revision.Apr 14 2017, 4:27 PM

This revision is now accepted and ready to land.Apr 14 2017, 4:27 PM

Closed by commit rP7274e4857c23: Fix a bug where Phortune could fatal while building crumbs (authored by epriestley, committed by epriestley). · Explain WhyApr 14 2017, 5:22 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phortune/

controller/

account/

PhortuneAccountProfileController.php

11 lines

Diff 42549

View Options

src/applications/phortune/controller/account/PhortuneAccountProfileController.php

Fix a bug where Phortune could fatal while building crumbsClosedPublicActions