Fix a bug where Phortune could fatal while building crumbs
7274e4857c23
Actions

Description

Fix a bug where Phortune could fatal while building crumbs

Summary: Ref T12451. $this->getAccount() may not return an account.

Test Plan:

Visit /phortune/X/, where X is the ID of an account you don't have permission to view.
Before patch: fatal.
After patch: normal policy exception page.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12451

Differential Revision: https://secure.phabricator.com/D17689

Details

Provenance

epriestley	Authored on Apr 14 2017, 4:16 PM
epriestley	Pushed on Apr 14 2017, 5:22 PM

Reviewer

chad

Differential Revision

D17689: Fix a bug where Phortune could fatal while building crumbs

Parents

rP1e43d57c8125: When closing tasks with "Fixes xxx", try to act more authentically as the…

Branches

Unknown

Tags

Unknown

Tasks

T12451: Finding your subscriptions / cards on Phacility is non-obvious

Build Status

Buildable 16480
Build 21945: Run Core Tests

Event Timeline

epriestley committed rP7274e4857c23: Fix a bug where Phortune could fatal while building crumbs (authored by epriestley).Apr 14 2017, 5:22 PM

epriestley added a task: T12451: Finding your subscriptions / cards on Phacility is non-obvious.

Harbormaster completed building B16480: rP7274e4857c23: Fix a bug where Phortune could fatal while building crumbs.Apr 14 2017, 5:24 PM

Changes (1)

Path

Size

src/

applications/

phortune/

controller/

account/

PhortuneAccountProfileController.php

rP7274e4857c23

View Options

src/applications/phortune/controller/account/PhortuneAccountProfileController.php