Page MenuHomePhabricator

Show users how fulltext search queries are parsed and executed; don't query stopwords or short tokens
ClosedPublic

Authored by epriestley on Apr 13 2017, 12:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 25, 5:13 PM
Unknown Object (File)
Wed, Mar 20, 11:59 PM
Unknown Object (File)
Feb 3 2024, 3:32 PM
Unknown Object (File)
Jan 30 2024, 7:03 PM
Unknown Object (File)
Jan 27 2024, 4:08 PM
Unknown Object (File)
Jan 11 2024, 1:37 AM
Unknown Object (File)
Dec 27 2023, 10:36 AM
Unknown Object (File)
Dec 27 2023, 10:36 AM
Subscribers
None

Details

Summary

Depends on D17670. Fixes T12137. Fixes T12003. Ref T2632.

This shows users a readout of which terms were actually searched for.

This also drops those terms from the query we submit to the backend, dodging the weird behaviors / search engine bugs in T12137.

This might need some design tweaking.

Test Plan

Screen Shot 2017-04-12 at 4.56.59 PM.png (493×851 px, 52 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  • Use phutil_utf8_strlen() for identifying short tokens.

InnoDB list is pretty conservative:

https://dev.mysql.com/doc/refman/5.7/en/fulltext-stopwords.html

| a     |
| about |
| an    |
| are   |
| as    |
| at    |
| be    |
| by    |
| com   |
| de    |
| en    |
| for   |
| from  |
| how   |
| i     |
| in    |
| is    |
| it    |
| la    |
| of    |
| on    |
| or    |
| that  |
| the   |
| this  |
| to    |
| was   |
| what  |
| when  |
| where |
| who   |
| will  |
| with  |
| und   |
| the   |
| www   |
This revision is now accepted and ready to land.Apr 13 2017, 1:59 AM
This revision was automatically updated to reflect the committed changes.