Sell Yellow! Buy Indigo!
ClosedPublic
Actions

Authored by epriestley on Apr 10 2017, 9:57 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 20, 10:20 AM

	Unknown Object (File)
	Tue, Dec 17, 10:19 PM

	Unknown Object (File)
	Wed, Dec 11, 6:00 AM

	Unknown Object (File)
	Mon, Dec 9, 1:19 PM

	Unknown Object (File)
	Mon, Dec 9, 1:19 PM

	Unknown Object (File)
	Mon, Dec 9, 1:15 PM

	Unknown Object (File)
	Mon, Dec 9, 1:02 PM

	Unknown Object (File)
	Sat, Dec 7, 5:59 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12504: Files "Temporary" badge is white-on-grey

Commits

rP49132b884b6f: Sell Yellow! Buy Indigo!

Summary

Fixes T12504. Replaces all tags with indigo.

Test Plan

Screen Shot 2017-04-10 at 2.55.50 PM.png (160×377 px, 13 KB)

Diff Detail

Repository

rP Phabricator

Branch

tbadge

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16376
Build 21781: Run Core Tests
Build 21780: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 10 2017, 9:57 PM

looks like yellow

chad accepted this revision.Apr 10 2017, 9:58 PM

This revision is now accepted and ready to land.Apr 10 2017, 9:58 PM

Harbormaster completed remote builds in B16376: Diff 42447.Apr 10 2017, 9:58 PM

(I honestly don't know what "temporary" means here.

When you do something like "View Raw File", Differential creates a temporary file and redirects you to it. Users won't normally view the detail pages for temporary files, but I was forced to look at some while fixing the "TTL" stuff in D17616.

Closed by commit rP49132b884b6f: Sell Yellow! Buy Indigo! (authored by epriestley, committed by epriestley). · Explain WhyApr 10 2017, 10:01 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

files/

controller/

PhabricatorFileInfoController.php

8 lines

Diff 42447

View Options

src/applications/files/controller/PhabricatorFileInfoController.php

Sell Yellow! Buy Indigo!ClosedPublicActions