Page MenuHomePhabricator

Reject ambiguous URIs with unescaped "#" or "?" in username/password parts
ClosedPublic

Authored by epriestley on Apr 10 2017, 4:54 PM.
Tags
None
Referenced Files
F15308848: D17647.id.diff
Thu, Mar 6, 6:43 AM
Unknown Object (File)
Sat, Mar 1, 10:17 PM
Unknown Object (File)
Mon, Feb 24, 1:55 AM
Unknown Object (File)
Fri, Feb 21, 3:20 PM
Unknown Object (File)
Feb 9 2025, 3:43 AM
Unknown Object (File)
Feb 9 2025, 3:43 AM
Unknown Object (File)
Feb 9 2025, 3:43 AM
Unknown Object (File)
Jan 29 2025, 2:23 AM
Subscribers
None

Details

Summary

Fixes T12526. These URIs are ambiguous and nonstandard, and different versions of different clients parse them differently.

Instead of trying to get this right across PHP versions, just reject these outright. No normal user will ever expect these to work.

Test Plan

Ran unit tests in PHP 7.1, got clean results. See T12526 for more discussion.

Diff Detail

Repository
rPHU libphutil
Branch
uri1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16370
Build 21772: Run Core Tests
Build 21771: arc lint + arc unit