Page MenuHomePhabricator

Fix an issue where recurring ghost events could go missing if queried with a limit
ClosedPublic

Authored by epriestley on Apr 10 2017, 1:33 PM.
Tags
None
Referenced Files
F13288009: D17645.diff
Tue, Jun 4, 9:40 AM
F13275886: D17645.diff
Fri, May 31, 5:18 AM
F13263463: D17645.diff
Mon, May 27, 9:37 AM
Unknown Object (File)
May 7 2024, 7:03 AM
Unknown Object (File)
May 3 2024, 5:04 AM
Unknown Object (File)
Apr 25 2024, 12:45 AM
Unknown Object (File)
Apr 11 2024, 8:34 AM
Unknown Object (File)
Mar 31 2024, 6:33 AM
Subscribers
None

Details

Summary

Ref T11816. Depends on D17644. When you executed a query like "upcoming, limit 5 events" you might match some recurring events starting from, say, a year ago and repeating every month.

We'd then generate the first 5 ghosts for these events (say, last January, February, ... May) and later throw them out, so the correct events in the query window (say, this April) would never get generated.

Instead, generate ghosts beginning with the start of the window. The fix in D17644 to number results correctly allows us to do this.

Test Plan
  • Made a query panel showing 5 events, scheduled an event long in the past, did not visit any of the instances of it so they didn't generate concrete objects.
  • Before the patch, near-future instances failed to show; after the patch, they show.

Diff Detail

Repository
rP Phabricator
Branch
cal4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16361
Build 21760: Run Core Tests
Build 21759: arc lint + arc unit