Page MenuHomePhabricator

Make Calendar recurrence sets return the indexes of recurrence dates properly
ClosedPublic

Authored by epriestley on Apr 10 2017, 1:28 PM.
Tags
None
Referenced Files
F13342721: D17644.diff
Thu, Jun 20, 5:00 PM
F13338530: D17644.diff
Wed, Jun 19, 11:05 AM
F13334055: D17644.diff
Tue, Jun 18, 4:02 PM
F13326295: D17644.diff
Sat, Jun 15, 3:28 AM
F13313694: D17644.diff
Tue, Jun 11, 9:52 AM
F13308151: D17644.id42431.diff
Mon, Jun 10, 12:59 AM
F13308012: D17644.id42438.diff
Sun, Jun 9, 11:57 PM
F13301054: D17644.diff
Fri, Jun 7, 2:52 PM
Subscribers
None

Details

Summary

Ref T11816. Currently, if you specify a start time, you get back indexes starting from that start time (0, 1, ...).

This can cause some bugs elsewhere when querying for recurring event ranges.

Instead, return the indexes consistently, even if there is a start time.

Test Plan

Added unit tests, made them pass. Fixed an existing unit test.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable