Page MenuHomePhabricator

Fix an issue where recurring ghost events could go missing if queried with a limit
ClosedPublic

Authored by epriestley on Apr 10 2017, 1:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 5:35 PM
Unknown Object (File)
Mon, Dec 9, 1:18 PM
Unknown Object (File)
Mon, Dec 9, 1:18 PM
Unknown Object (File)
Mon, Dec 9, 1:14 PM
Unknown Object (File)
Mon, Dec 9, 1:02 PM
Unknown Object (File)
Wed, Nov 27, 11:42 PM
Unknown Object (File)
Thu, Nov 21, 7:44 PM
Unknown Object (File)
Tue, Nov 19, 8:19 PM
Subscribers
None

Details

Summary

Ref T11816. Depends on D17644. When you executed a query like "upcoming, limit 5 events" you might match some recurring events starting from, say, a year ago and repeating every month.

We'd then generate the first 5 ghosts for these events (say, last January, February, ... May) and later throw them out, so the correct events in the query window (say, this April) would never get generated.

Instead, generate ghosts beginning with the start of the window. The fix in D17644 to number results correctly allows us to do this.

Test Plan
  • Made a query panel showing 5 events, scheduled an event long in the past, did not visit any of the instances of it so they didn't generate concrete objects.
  • Before the patch, near-future instances failed to show; after the patch, they show.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable