Make Calendar recurrence sets return the indexes of recurrence dates properly
ClosedPublic
Actions

Authored by epriestley on Apr 10 2017, 1:28 PM.

Details

Reviewers

chad

Maniphest Tasks

T11816: Calendar: Feedback and Suggestions

Commits

Summary

Ref T11816. Currently, if you specify a start time, you get back indexes starting from that start time (0, 1, ...).

This can cause some bugs elsewhere when querying for recurring event ranges.

Instead, return the indexes consistently, even if there is a start time.

Test Plan

Added unit tests, made them pass. Fixed an existing unit test.

Repository

rPHU libphutil

Branch

cal3

Lint

Lint Passed

Unit

Test Failures

Build Status

	Time	Test
	0 ms	PhutilURITestCase::Unknown Unit Message ("") Assertion failed, expected values to be equal (at PhutilURITestCase.php:87). Expected: 'good.com#u' Actual: ''
	1 ms	AbstractDirectedGraphTestCase::Unknown Unit Message ("") 25 assertions passed.
	0 ms	AbstractDirectedGraphTestCase::Unknown Unit Message ("") 1 assertion passed.
	0 ms	AbstractDirectedGraphTestCase::Unknown Unit Message ("") 1 assertion passed.
	0 ms	AbstractDirectedGraphTestCase::Unknown Unit Message ("") 1 assertion passed.
		View Full Test Results (1 Failed · 395 Passed · 2 Skipped)