Page MenuHomePhabricator
Differential D17611

Move Files editing and commenting to EditEngine
ClosedPublic
Actions

Authored by epriestley on Apr 4 2017, 3:04 PM.
Tags
None
Referenced Files
F13090793: D17611.diff
Thu, Apr 25, 2:34 AM
Unknown Object (File)
Thu, Apr 11, 9:54 AM
Unknown Object (File)
Wed, Apr 10, 11:03 AM
Unknown Object (File)
Wed, Apr 10, 3:03 AM
Unknown Object (File)
Wed, Apr 10, 2:28 AM
Unknown Object (File)
Wed, Apr 10, 12:45 AM
Unknown Object (File)
Tue, Apr 9, 10:51 PM
Unknown Object (File)
Tue, Apr 9, 6:40 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11357: Move Files to EditEngine and modern APIs
Commits
rP260a08a1282d: Move Files editing and commenting to EditEngine
Summary

Ref T11357. This moves editing and commenting (but not creation) to EditEngine.

Since only the name is really editable, this is pretty straightforward.

Test Plan

Renamed files; commented on files.

Diff Detail

Repository
rP Phabricator
Branch
files2
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/files/editor/PhabricatorFileEditEngine.php:17XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 16282
Build 21640: Run Core Tests
Build 21639: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 4 2017, 3:04 PM
Harbormaster completed remote builds in B16282: Diff 42355.Apr 4 2017, 3:06 PM
epriestley mentioned this in D17613: Only require POST to fetch file data if the viewer is logged in.Apr 4 2017, 4:10 PM
chad edited edge metadata.Apr 4 2017, 5:21 PM

Does this work with FileLightboxController?

epriestley added a comment.Apr 4 2017, 5:21 PM

Oh, good though.

epriestley added a comment.Apr 4 2017, 5:23 PM

Yes, this doesn't disrupt that controller. At some point that controller should be merged into EditEngine, presumably, but I'm not planning to touch it for now:

Screen Shot 2017-04-04 at 10.23.05 AM.png (922×1 px, 559 KB)

chad accepted this revision.Apr 4 2017, 5:59 PM
This revision is now accepted and ready to land.Apr 4 2017, 5:59 PM
Closed by commit rP260a08a1282d: Move Files editing and commenting to EditEngine (authored by epriestley, committed by epriestley). · Explain WhyApr 4 2017, 11:15 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in rP2896da384cb7: Only require POST to fetch file data if the viewer is logged in.

Revision Contents
Changeset List

Diff 42355

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/files/application/PhabricatorFilesApplication.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileCommentController.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileEditController.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileInfoController.php

Loading...
View Options

src/applications/files/editor/PhabricatorFileEditEngine.php

Loading...
View Options

src/applications/files/storage/PhabricatorFile.php

Loading...
Phabricator · Built by Phacility