Page MenuHomePhabricator

Move Files editing and commenting to EditEngine
ClosedPublic

Authored by epriestley on Apr 4 2017, 3:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 15 2024, 12:51 AM
Unknown Object (File)
Feb 9 2024, 4:45 PM
Unknown Object (File)
Jan 29 2024, 8:39 AM
Unknown Object (File)
Jan 6 2024, 12:57 AM
Unknown Object (File)
Nov 29 2023, 11:39 PM
Unknown Object (File)
Nov 25 2023, 10:59 AM
Unknown Object (File)
Nov 25 2023, 6:29 AM
Unknown Object (File)
Nov 15 2023, 1:45 AM
Subscribers
None

Details

Summary

Ref T11357. This moves editing and commenting (but not creation) to EditEngine.

Since only the name is really editable, this is pretty straightforward.

Test Plan

Renamed files; commented on files.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Does this work with FileLightboxController?

Yes, this doesn't disrupt that controller. At some point that controller should be merged into EditEngine, presumably, but I'm not planning to touch it for now:

Screen Shot 2017-04-04 at 10.23.05 AM.png (922×1 px, 559 KB)

This revision is now accepted and ready to land.Apr 4 2017, 5:59 PM