Page MenuHomePhabricator

Move Files editing and commenting to EditEngine
ClosedPublic

Authored by epriestley on Apr 4 2017, 3:04 PM.

Details

Summary

Ref T11357. This moves editing and commenting (but not creation) to EditEngine.

Since only the name is really editable, this is pretty straightforward.

Test Plan

Renamed files; commented on files.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Apr 4 2017, 3:04 PM
chad edited edge metadata.Apr 4 2017, 5:21 PM

Does this work with FileLightboxController?

Oh, good though.

Yes, this doesn't disrupt that controller. At some point that controller should be merged into EditEngine, presumably, but I'm not planning to touch it for now:

chad accepted this revision.Apr 4 2017, 5:59 PM
This revision is now accepted and ready to land.Apr 4 2017, 5:59 PM
This revision was automatically updated to reflect the committed changes.