Page MenuHomePhabricator

Re-run config validation from `bin/search`
ClosedPublic

Authored by epriestley on Mar 28 2017, 8:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 1:26 AM
Unknown Object (File)
Sat, Nov 30, 6:35 AM
Unknown Object (File)
Oct 21 2024, 3:53 PM
Unknown Object (File)
Oct 19 2024, 8:52 AM
Unknown Object (File)
Oct 18 2024, 5:21 PM
Unknown Object (File)
Oct 14 2024, 9:57 PM
Unknown Object (File)
Oct 14 2024, 3:17 AM
Unknown Object (File)
Oct 6 2024, 1:45 PM
Subscribers
None

Details

Summary

Ref T12450. Normally, we validate config when:

  • You restart the webserver.
  • You edit it with bin/config set ....
  • You edit it with the web UI.

However, you can also change config by editing local.json, some_env.conf.php, a SiteConfig class, etc. In these cases, you may miss config warnings.

Explicitly re-run search config checks from bin/search, similar to the additional database checks we run from bin/storage, to try to produce a better error message if the user has made a configuration error.

Test Plan
$ ./bin/search init
Usage Exception: Setting "cluster.search" is misconfigured: Invalid search engine type: elastic. Valid types are: elasticsearch, mysql.

Diff Detail

Repository
rP Phabricator
Branch
search4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16203
Build 21515: Run Core Tests
Build 21514: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Mar 28 2017, 9:46 PM
This revision was automatically updated to reflect the committed changes.