Page MenuHomePhabricator

Re-run config validation from `bin/search`
ClosedPublic

Authored by epriestley on Mar 28 2017, 8:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 15 2017, 8:55 PM
Unknown Object (File)
Apr 10 2017, 11:35 AM
Unknown Object (File)
Apr 10 2017, 11:35 AM
Unknown Object (File)
Apr 10 2017, 11:35 AM
Unknown Object (File)
Apr 9 2017, 1:32 AM
Unknown Object (File)
Apr 5 2017, 1:30 AM
Unknown Object (File)
Apr 3 2017, 10:13 PM
Unknown Object (File)
Mar 31 2017, 5:36 PM
Subscribers
None

Details

Summary

Ref T12450. Normally, we validate config when:

  • You restart the webserver.
  • You edit it with bin/config set ....
  • You edit it with the web UI.

However, you can also change config by editing local.json, some_env.conf.php, a SiteConfig class, etc. In these cases, you may miss config warnings.

Explicitly re-run search config checks from bin/search, similar to the additional database checks we run from bin/storage, to try to produce a better error message if the user has made a configuration error.

Test Plan
$ ./bin/search init
Usage Exception: Setting "cluster.search" is misconfigured: Invalid search engine type: elastic. Valid types are: elasticsearch, mysql.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 28 2017, 9:46 PM
This revision was automatically updated to reflect the committed changes.