Page MenuHomePhabricator

Make `bin/search init` messaging a little more consistent
ClosedPublic

Authored by epriestley on Mar 28 2017, 7:55 PM.
Tags
None
Referenced Files
F18836748: D17572.diff
Mon, Oct 27, 3:28 AM
F18732511: D17572.diff
Sep 30 2025, 6:34 PM
F18679083: D17572.id.diff
Sep 26 2025, 12:31 AM
F18621547: D17572.id42275.diff
Sep 15 2025, 8:43 AM
F18567322: D17572.id.diff
Sep 9 2025, 3:41 PM
Unknown Object (File)
Jun 29 2025, 7:19 AM
Unknown Object (File)
May 29 2025, 9:12 AM
Unknown Object (File)
May 10 2025, 6:51 AM
Subscribers
None

Details

Summary

Ref T12450. This mostly just smooths out the text a little to improve consistency. Also:

  • Use isWritable().
  • Make the "skipping because not writable" message more clear and tailored.
  • Try not to use the word "index" too much to avoid confusion with bin/search index -- instead, talk about "initialize a service".
Test Plan

Ran bin/search init with a couple of different (writable / not writable) configs, saw slightly clearer messaging.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable