Page MenuHomePhabricator

Make `bin/search init` messaging a little more consistent
ClosedPublic

Authored by epriestley on Mar 28 2017, 7:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 25, 2:37 PM
Unknown Object (File)
Fri, Jan 24, 7:50 PM
Unknown Object (File)
Fri, Jan 24, 7:50 PM
Unknown Object (File)
Fri, Jan 24, 7:50 PM
Unknown Object (File)
Tue, Jan 21, 9:33 AM
Unknown Object (File)
Fri, Jan 17, 8:13 PM
Unknown Object (File)
Dec 20 2024, 3:34 PM
Unknown Object (File)
Dec 14 2024, 4:14 PM
Subscribers
None

Details

Summary

Ref T12450. This mostly just smooths out the text a little to improve consistency. Also:

  • Use isWritable().
  • Make the "skipping because not writable" message more clear and tailored.
  • Try not to use the word "index" too much to avoid confusion with bin/search index -- instead, talk about "initialize a service".
Test Plan

Ran bin/search init with a couple of different (writable / not writable) configs, saw slightly clearer messaging.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable