Differential D17566

Fix an issue where "Request Review" of a fully-accepted revision would transition to "Accepted"
ClosedPublic
Actions

Authored by epriestley on Mar 28 2017, 12:52 PM.

Tags

None

Referenced Files

	F19105258: D17566.id.diff
	Fri, Dec 5, 11:06 PM

	F19098069: D17566.diff
	Thu, Dec 4, 3:45 PM

	F19051558: D17566.id42263.diff
	Fri, Nov 28, 1:16 AM

	F19022917: D17566.diff
	Sun, Nov 23, 10:29 PM

	F18951855: D17566.diff
	Nov 12 2025, 4:54 AM

	F18871496: D17566.id.diff
	Nov 4 2025, 11:03 PM

	F18866103: D17566.diff
	Nov 3 2025, 3:27 PM

	F18841245: D17566.id42263.diff
	Oct 28 2025, 7:53 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10967: Move Differential reviewers back to a dedicated database storage table

Commits

rPaea46e55dac0: Fix an issue where "Request Review" of a fully-accepted revision would…

Summary

Ref T10967. This is explained in more detail in T10967#217125

When an author does "Request Review" on an accepted revision, void (in the sense of "cancel out", like a bank check) any "accepted" reviewers on the current diff.

Test Plan

Create a revision with author A and reviewer B.
Accept as B.
"Request Review" as A.
(With sticky accepts enabled.)
Before patch: revision swithced back to "accepted".
After patch: the earlier review is "voided" by te "Request Review", and the revision switches to "Review Requested".

Diff Detail

Repository

Branch

review1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16188
Build 21491: Run Core Tests
Build 21490: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 28 2017, 12:52 PM

Harbormaster completed remote builds in B16188: Diff 42263.Mar 28 2017, 12:53 PM

epriestley mentioned this in D17568: When voiding "Accept" reviews, also void "Reject" reviews.Mar 28 2017, 1:24 PM

chad accepted this revision.Mar 28 2017, 5:28 PM

This revision is now accepted and ready to land.Mar 28 2017, 5:28 PM

Closed by commit rPaea46e55dac0: Fix an issue where "Request Review" of a fully-accepted revision would… (authored by epriestley, committed by epriestley). · Explain WhyMar 28 2017, 6:50 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in rPddc02ce420a5: When voiding "Accept" reviews, also void "Reject" reviews.

epriestley mentioned this in D17605: Don't downgrade accepts on update (fix "sticky accept").Apr 3 2017, 3:38 PM

epriestley mentioned this in rP9ebb5f8cda56: Don't downgrade accepts on update (fix "sticky accept").Apr 3 2017, 4:55 PM

epriestley mentioned this in rP520d3b939204: (stable) Don't downgrade accepts on update (fix "sticky accept").Apr 5 2017, 1:35 AM

epriestley mentioned this in T10828: File deletion should be queued up and run by daemons.Apr 9 2017, 11:13 AM

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20170328.reviewers.01.void.sql

2 lines

src/

__phutil_library_map__.php

2 lines

applications/

differential/

editor/

DifferentialTransactionEditor.php

13 lines

storage/

DifferentialReviewer.php

9 lines

xaction/

DifferentialRevisionReviewTransaction.php

41 lines

DifferentialRevisionVoidTransaction.php

63 lines

Diff 42263

resources/sql/autopatches/20170328.reviewers.01.void.sql

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...

src/applications/differential/storage/DifferentialReviewer.php

Loading...

src/applications/differential/xaction/DifferentialRevisionReviewTransaction.php

Loading...

src/applications/differential/xaction/DifferentialRevisionVoidTransaction.php

Loading...