Page MenuHomePhabricator
Differential D17568

When voiding "Accept" reviews, also void "Reject" reviews
ClosedPublic
Actions

Authored by epriestley on Mar 28 2017, 1:24 PM.
Tags
None
Referenced Files
F13769164: D17568.id42265.diff
Sat, Sep 7, 6:28 PM
F13768268: D17568.diff
Sat, Sep 7, 8:54 AM
Unknown Object (File)
Thu, Sep 5, 11:32 PM
Unknown Object (File)
Sun, Sep 1, 6:50 PM
Unknown Object (File)
Sun, Sep 1, 1:01 PM
Unknown Object (File)
Tue, Aug 20, 9:26 AM
Unknown Object (File)
Sun, Aug 18, 8:02 PM
Unknown Object (File)
Fri, Aug 16, 10:07 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10967: Move Differential reviewers back to a dedicated database storage table
Commits
rPddc02ce420a5: When voiding "Accept" reviews, also void "Reject" reviews
Summary

Ref T10967. This change is similar to D17566, but for rejects.

Test Plan
  • Create a revision as A, with reviewer B.
  • Reject as B.
  • Request review as A.
  • Before patch: stuck in "rejected".
  • After patch: transitions back to "needs review".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 28 2017, 1:24 PM
Harbormaster completed remote builds in B16190: Diff 42265.Mar 28 2017, 1:25 PM
chad accepted this revision.Mar 28 2017, 5:50 PM
This revision is now accepted and ready to land.Mar 28 2017, 5:50 PM
Closed by commit rPddc02ce420a5: When voiding "Accept" reviews, also void "Reject" reviews (authored by epriestley, committed by epriestley). · Explain WhyMar 28 2017, 6:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 42272

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/applications/differential/storage/DifferentialReviewer.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionReviewTransaction.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionVoidTransaction.php

Loading...
Phabricator · Built by Phacility