Page MenuHomePhabricator

When voiding "Accept" reviews, also void "Reject" reviews
ClosedPublic

Authored by epriestley on Mar 28 2017, 1:24 PM.
Tags
None
Referenced Files
F18698875: D17568.diff
Sat, Sep 27, 11:59 AM
F18632332: D17568.id42272.diff
Tue, Sep 16, 5:38 PM
F18619347: D17568.id42272.diff
Mon, Sep 15, 2:18 AM
F18475224: D17568.id.diff
Sep 2 2025, 11:19 PM
F18461620: D17568.diff
Sep 1 2025, 8:51 PM
F18230069: D17568.diff
Aug 20 2025, 11:57 AM
F17950879: D17568.id.diff
Aug 1 2025, 12:46 AM
F17934602: D17568.diff
Jul 30 2025, 10:42 PM
Subscribers
None

Details

Summary

Ref T10967. This change is similar to D17566, but for rejects.

Test Plan
  • Create a revision as A, with reviewer B.
  • Reject as B.
  • Request review as A.
  • Before patch: stuck in "rejected".
  • After patch: transitions back to "needs review".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 28 2017, 5:50 PM
This revision was automatically updated to reflect the committed changes.