Page MenuHomePhabricator

Don't downgrade accepts on update (fix "sticky accept")
ClosedPublic

Authored by epriestley on Apr 3 2017, 3:38 PM.
Tags
None
Referenced Files
F19032667: D17605.id.diff
Tue, Nov 25, 7:13 AM
F19025987: D17605.diff
Mon, Nov 24, 9:17 AM
F18819846: D17605.id.diff
Oct 22 2025, 10:13 AM
F18817970: D17605.diff
Oct 21 2025, 7:59 PM
F18741077: D17605.id.diff
Oct 2 2025, 8:27 AM
F18714255: D17605.id42348.diff
Sep 29 2025, 7:25 AM
F18625942: D17605.id42348.diff
Sep 15 2025, 11:58 PM
F18597388: D17605.diff
Sep 13 2025, 2:45 AM
Subscribers
None

Details

Summary

Fixes T12496. Sticky accept was accidentally impacted by the "void" changes in D17566.

Instead, don't always downgrade all accepts/rejects: on update, we only want to downgrade accepts.

Test Plan
  • With sticky accept off, updated an accepted revision: new state is "needs review".
  • With sticky accept on, updated an accepted revision: new state is "accepted" (sticky accept working correctly).
  • Did "reject" + "request review" to make sure that still works, worked fine.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 3 2017, 4:54 PM
This revision was automatically updated to reflect the committed changes.