Page MenuHomePhabricator

Fix an issue where "Request Review" of a fully-accepted revision would transition to "Accepted"
ClosedPublic

Authored by epriestley on Mar 28 2017, 12:52 PM.
Tags
None
Referenced Files
F19539016: D17566.diff
Jan 21 2026, 4:52 PM
F19466054: D17566.id42270.diff
Jan 3 2026, 7:38 AM
F19105258: D17566.id.diff
Dec 5 2025, 11:06 PM
F19098069: D17566.diff
Dec 4 2025, 3:45 PM
F19051558: D17566.id42263.diff
Nov 28 2025, 1:16 AM
F19022917: D17566.diff
Nov 23 2025, 10:29 PM
F18951855: D17566.diff
Nov 12 2025, 4:54 AM
F18871496: D17566.id.diff
Nov 4 2025, 11:03 PM
Subscribers
None

Details

Summary

Ref T10967. This is explained in more detail in T10967#217125

When an author does "Request Review" on an accepted revision, void (in the sense of "cancel out", like a bank check) any "accepted" reviewers on the current diff.

Test Plan
  • Create a revision with author A and reviewer B.
  • Accept as B.
  • "Request Review" as A.
  • (With sticky accepts enabled.)
  • Before patch: revision swithced back to "accepted".
  • After patch: the earlier review is "voided" by te "Request Review", and the revision switches to "Review Requested".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable