Remove duplicate "Change Default Values" action in form editing workflow
ClosedPublic
Actions

Authored by epriestley on Mar 22 2017, 12:03 PM.

Details

Reviewers

chad
cspeckmim

Maniphest Tasks

T12434: Editing Maniphest's EditEngine form shows "Change Default Values" twice

Commits

rP3d35d6d3f901: Remove duplicate "Change Default Values" action in form editing workflow

Summary

Fixes T12434. I accidentally copy/pasted this too much in D17442.

Test Plan

Viewed a form edit page, no longer saw two copies of this action.

Diff Detail

Repository

rP Phabricator

Branch

defaultvalues1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16082
Build 21337: Run Core Tests
Build 21336: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 22 2017, 12:03 PM

Harbormaster completed remote builds in B16082: Diff 42167.Mar 22 2017, 12:04 PM

chad accepted this revision.Mar 22 2017, 2:57 PM

This revision is now accepted and ready to land.Mar 22 2017, 2:57 PM

Closed by commit rP3d35d6d3f901: Remove duplicate "Change Default Values" action in form editing workflow (authored by epriestley, committed by epriestley). · Explain WhyMar 22 2017, 4:50 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

controller/

PhabricatorEditEngineConfigurationViewController.php

9 lines

Diff 42167

View Options

src/applications/transactions/controller/PhabricatorEditEngineConfigurationViewController.php

Remove duplicate "Change Default Values" action in form editing workflowClosedPublicActions