Page MenuHomePhabricator

Allow EditEngine forms for objects which support subtyping to have a subtype configured
ClosedPublic

Authored by epriestley on Mar 2 2017, 12:08 AM.

Details

Summary

Ref T12314. This adds a "Change Form Subtype" workflow to the EditEngine form configuration screen, for forms that edit/create objects which support subtyping (for now, only tasks).

For example, this allows you to switch a form from being a "task" form to a "plant" or "animal" form.

Doing this doesn't yet do anything useful or interesting. I'm also not showing it in the UI yet since I'm not sure what we should make that look like (presumably, we should just echo whatever UI we end up with on tasks).

Test Plan
  • Changed the subtype of a task form.
  • Verified that the "Change Subtype" action doesn't appear on other forms (for example, those for Pastes).

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mar 2 2017, 12:08 AM
chad accepted this revision.Mar 2 2017, 12:28 AM
chad added inline comments.
src/applications/transactions/controller/PhabricatorEditEngineConfigurationViewController.php
160

que?

This revision is now accepted and ready to land.Mar 2 2017, 12:28 AM

Got something better? Nothing struck me as too "subtypey", but the driver's license one looks like a little card or something. 🐈

This revision was automatically updated to reflect the committed changes.