Try to guess a name for the 'Add to Dashboard' workflow
ClosedPublic
Actions

Authored by chad on Mar 21 2017, 12:31 AM.

Tags

None

Referenced Files

	F15542072: D17523.id42147.diff
	Fri, Apr 25, 3:26 PM

	F15535324: D17523.diff
	Thu, Apr 24, 4:33 AM

	F15520047: D17523.id42147.diff
	Sun, Apr 20, 2:55 AM

	F15510039: D17523.id42149.diff
	Wed, Apr 16, 6:17 PM

	F15502247: D17523.id42147.diff
	Sun, Apr 13, 11:15 PM

	F15500888: D17523.id42149.diff
	Sun, Apr 13, 7:51 PM

	F15485787: D17523.diff
	Thu, Apr 10, 2:25 AM

	F15463508: D17523.id42148.diff
	Wed, Apr 2, 12:21 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T5307: UX for taking actions with search results

Commits

rP1a5d92184cb6: Try to guess a name for the 'Add to Dashboard' workflow

Summary

Ref T5307. Just makes the dialog a little easier to use. Picks a name if we already have one.

Test Plan

Test a builtin, custom saved, and a new advanced search (no name).

Diff Detail

Repository

rP Phabricator

Branch

tarnation-3 (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16062
Build 21303: Run Core Tests
Build 21302: arc lint + arc unit

Event Timeline

chad created this revision.Mar 21 2017, 12:31 AM

Herald added a subscriber: Korvin. · View Herald TranscriptMar 21 2017, 12:31 AM

Harbormaster completed remote builds in B16062: Diff 42147.Mar 21 2017, 12:32 AM

epriestley accepted this revision.Mar 21 2017, 12:38 AM

epriestley added inline comments.

src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php
50	You can just do the load bit here, right? There are two branches and we're running the same code on both?

This revision is now accepted and ready to land.Mar 21 2017, 12:38 AM

derp

Harbormaster completed remote builds in B16063: Diff 42148.Mar 21 2017, 12:45 AM

Closed by commit rP1a5d92184cb6: Try to guess a name for the 'Add to Dashboard' workflow (authored by chad, committed by chad). · Explain WhyMar 21 2017, 1:02 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

dashboard/

controller/

PhabricatorDashboardQueryPanelInstallController.php

7 lines

Diff 42147

View Options

src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php

Try to guess a name for the 'Add to Dashboard' workflowClosedPublicActions