Page MenuHomePhabricator

Try to guess a name for the 'Add to Dashboard' workflow
ClosedPublic

Authored by chad on Mar 21 2017, 12:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 10:52 PM
Unknown Object (File)
Mon, Dec 16, 9:15 PM
Unknown Object (File)
Mon, Dec 16, 9:15 PM
Unknown Object (File)
Mon, Dec 16, 9:15 PM
Unknown Object (File)
Mon, Dec 16, 9:08 PM
Unknown Object (File)
Mon, Dec 16, 8:56 PM
Unknown Object (File)
Sun, Dec 15, 4:39 PM
Unknown Object (File)
Fri, Dec 13, 8:48 PM
Subscribers

Details

Summary

Ref T5307. Just makes the dialog a little easier to use. Picks a name if we already have one.

Test Plan

Test a builtin, custom saved, and a new advanced search (no name).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley added inline comments.
src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php
47–52

You can just do the load bit here, right? There are two branches and we're running the same code on both?

This revision is now accepted and ready to land.Mar 21 2017, 12:38 AM
This revision was automatically updated to reflect the committed changes.