Fix 'Add to Dashboard' issue with builtins
ClosedPublic
Actions

Authored by chad on Mar 20 2017, 10:05 PM.

Tags

None

Referenced Files

	F14758092: D17521.diff
	Wed, Jan 22, 4:59 AM

	F14750942: D17521.id.diff
	Tue, Jan 21, 12:03 PM

	Unknown Object (File)
	Fri, Jan 17, 11:47 PM

	Unknown Object (File)
	Sat, Jan 11, 3:51 AM

	Unknown Object (File)
	Dec 19 2024, 11:20 PM

	Unknown Object (File)
	Dec 6 2024, 2:43 PM

	Unknown Object (File)
	Nov 28 2024, 1:47 AM

	Unknown Object (File)
	Nov 19 2024, 5:06 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T5307: UX for taking actions with search results

Commits

rPe69f8f717b80: Fix 'Add to Dashboard' issue with builtins

Summary

Ref T5307. Actually check the built in query with query, not engine.

Test Plan

Try a builtin query, and a custom query when making a dashboard panel.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Mar 20 2017, 10:05 PM

Herald added a subscriber: Korvin. · View Herald TranscriptMar 20 2017, 10:05 PM

epriestley accepted this revision.Mar 20 2017, 10:06 PM

This revision is now accepted and ready to land.Mar 20 2017, 10:06 PM

Harbormaster completed remote builds in B16048: Diff 42133.Mar 20 2017, 10:06 PM

Closed by commit rPe69f8f717b80: Fix 'Add to Dashboard' issue with builtins (authored by chad, committed by chad). · Explain WhyMar 20 2017, 10:07 PM

This revision was automatically updated to reflect the committed changes.

I'm tempted to make the burger menu just a button if there is a single action.

Revision Contents
Changeset List

Path

Size

src/

applications/

dashboard/

controller/

PhabricatorDashboardQueryPanelInstallController.php

2 lines

Diff 42134

View Options

src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php

Fix 'Add to Dashboard' issue with builtinsClosedPublicActions