Fix 'Add to Dashboard' issue with builtins
ClosedPublic
Actions

Authored by chad on Mar 20 2017, 10:05 PM.

Tags

None

Referenced Files

	F15523846: D17521.id.diff
	Mon, Apr 21, 4:03 AM

	F15502403: D17521.id42134.diff
	Mon, Apr 14, 12:23 AM

	F15494441: D17521.id42133.diff
	Sat, Apr 12, 11:51 PM

	F15470944: D17521.id42134.diff
	Sat, Apr 5, 2:17 AM

	F15462417: D17521.id.diff
	Tue, Apr 1, 3:02 PM

	F15459799: D17521.diff
	Mon, Mar 31, 4:16 PM

	F15454468: D17521.id42133.diff
	Sat, Mar 29, 6:38 PM

	F15445839: D17521.id42134.diff
	Thu, Mar 27, 4:12 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T5307: UX for taking actions with search results

Commits

rPe69f8f717b80: Fix 'Add to Dashboard' issue with builtins

Summary

Ref T5307. Actually check the built in query with query, not engine.

Test Plan

Try a builtin query, and a custom query when making a dashboard panel.

Diff Detail

Repository

rP Phabricator

Branch

tarnation-2 (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16048
Build 21285: Run Core Tests
Build 21284: arc lint + arc unit

Event Timeline

chad created this revision.Mar 20 2017, 10:05 PM

Herald added a subscriber: Korvin. · View Herald TranscriptMar 20 2017, 10:05 PM

epriestley accepted this revision.Mar 20 2017, 10:06 PM

This revision is now accepted and ready to land.Mar 20 2017, 10:06 PM

Harbormaster completed remote builds in B16048: Diff 42133.Mar 20 2017, 10:06 PM

Closed by commit rPe69f8f717b80: Fix 'Add to Dashboard' issue with builtins (authored by chad, committed by chad). · Explain WhyMar 20 2017, 10:07 PM

This revision was automatically updated to reflect the committed changes.

I'm tempted to make the burger menu just a button if there is a single action.

Revision Contents
Changeset List

Path

Size

src/

applications/

dashboard/

controller/

PhabricatorDashboardQueryPanelInstallController.php

2 lines

Diff 42133

View Options

src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php

Fix 'Add to Dashboard' issue with builtinsClosedPublicActions