Differential D17436

Remove "disabled" look to subprojects/workboard nav items
ClosedPublic
Actions

Authored by chad on Mar 1 2017, 1:14 AM.

Details

Reviewers

epriestley

Maniphest Tasks

T12330: Subprojects link not grayed out in dark background of project workboards.

Commits

rPbf0a7cbec692: Remove "disabled" look to subprojects/workboard nav items

Summary

Fixes T12330. Minor UI nit, since we use "disabled" to usually mean "no permission". Makes these links always normal looking.

Test Plan

Review a new project in sandbox.

Diff Detail

Repository

rP Phabricator

Branch

workboard (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15830
Build 20939: Run Core Tests
Build 20938: arc lint + arc unit

Event Timeline

chad created this revision.Mar 1 2017, 1:14 AM

Herald added a subscriber: Korvin. · View Herald TranscriptMar 1 2017, 1:14 AM

Harbormaster completed remote builds in B15830: Diff 41926.Mar 1 2017, 1:15 AM

epriestley accepted this revision.Mar 1 2017, 3:45 PM

This revision is now accepted and ready to land.Mar 1 2017, 3:45 PM

Closed by commit rPbf0a7cbec692: Remove "disabled" look to subprojects/workboard nav items (authored by chad, committed by chad). · Explain WhyMar 1 2017, 5:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

menuitem/

PhabricatorProjectSubprojectsProfileMenuItem.php

5 lines

PhabricatorProjectWorkboardProfileMenuItem.php

3 lines

Diff 41926

View Options

src/applications/project/menuitem/PhabricatorProjectSubprojectsProfileMenuItem.php