Remove "disabled" look to subprojects/workboard nav items
ClosedPublic
Actions

Authored by chad on Mar 1 2017, 1:14 AM.

Tags

None

Referenced Files

	F13158130: D17436.diff
	Sun, May 5, 4:34 PM

	F13152608: D17436.id41926.diff
	Sat, May 4, 8:31 PM

	Unknown Object (File)
	Thu, May 2, 3:30 AM

	Unknown Object (File)
	Mon, Apr 29, 1:37 PM

	Unknown Object (File)
	Wed, Apr 24, 9:50 PM

	Unknown Object (File)
	Sun, Apr 21, 3:41 PM

	Unknown Object (File)
	Sat, Apr 20, 7:51 PM

	Unknown Object (File)
	Wed, Apr 17, 2:30 PM

View All 65 Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T12330: Subprojects link not grayed out in dark background of project workboards.

Commits

rPbf0a7cbec692: Remove "disabled" look to subprojects/workboard nav items

Summary

Fixes T12330. Minor UI nit, since we use "disabled" to usually mean "no permission". Makes these links always normal looking.

Test Plan

Review a new project in sandbox.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Mar 1 2017, 1:14 AM

Herald added a subscriber: Korvin. · View Herald TranscriptMar 1 2017, 1:14 AM

Harbormaster completed remote builds in B15830: Diff 41926.Mar 1 2017, 1:15 AM

epriestley accepted this revision.Mar 1 2017, 3:45 PM

This revision is now accepted and ready to land.Mar 1 2017, 3:45 PM

Closed by commit rPbf0a7cbec692: Remove "disabled" look to subprojects/workboard nav items (authored by chad, committed by chad). · Explain WhyMar 1 2017, 5:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

menuitem/

PhabricatorProjectSubprojectsProfileMenuItem.php

5 lines

PhabricatorProjectWorkboardProfileMenuItem.php

3 lines

Diff 41927

View Options

src/applications/project/menuitem/PhabricatorProjectSubprojectsProfileMenuItem.php