Page MenuHomePhabricator
Differential D17435

Minor fix presumably identified by PHPStan
ClosedPublic
Actions

Authored by joshuaspence on Feb 28 2017, 8:41 PM.
Tags
None
Referenced Files
F14972373: D17435.diff
Sun, Feb 16, 12:18 PM
Unknown Object (File)
Thu, Feb 13, 11:54 PM
Unknown Object (File)
Wed, Feb 12, 2:36 PM
Unknown Object (File)
Sun, Feb 9, 3:24 AM
Unknown Object (File)
Sun, Feb 9, 3:07 AM
Unknown Object (File)
Wed, Feb 5, 6:46 PM
Unknown Object (File)
Mon, Feb 3, 2:57 AM
Unknown Object (File)
Wed, Jan 29, 3:38 PM
View All Files
Subscribers
Firehed
Korvin
vrana

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU81494451f9be: Minor fix presumably identified by PHPStan
Summary

Address comments from @vrana, see D14512#207302.

Test Plan

Ran unit tests.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 15826
Build 20932: Run Core Tests
Build 20931: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
1 msPhutilURITestCase::Unknown Unit Message ("")
Assertion failed, expected values to be equal (at PhutilURITestCase.php:87). Expected: 'good.com#u' Actual: ''
1 msAbstractDirectedGraphTestCase::Unknown Unit Message ("")
25 assertions passed.
0 msAbstractDirectedGraphTestCase::Unknown Unit Message ("")
1 assertion passed.
0 msAbstractDirectedGraphTestCase::Unknown Unit Message ("")
2 assertions passed.
0 msAbstractDirectedGraphTestCase::Unknown Unit Message ("")
1 assertion passed.
View Full Test Results (1 Failed · 385 Passed · 2 Skipped)

Event Timeline

joshuaspence created this revision.Feb 28 2017, 8:41 PM
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 28 2017, 8:41 PM
Herald added subscribers: Firehed, Korvin. · View Herald Transcript
epriestley accepted this revision.Feb 28 2017, 8:41 PM

Unit test thing is a PHP7 thing.

This revision is now accepted and ready to land.Feb 28 2017, 8:41 PM
joshuaspence added a comment.Feb 28 2017, 8:42 PM
In D17435#208504, @epriestley wrote:

Unit test thing is a PHP7 thing.

Are you sure?

> php -v
PHP 5.6.30-1+deb.sury.org~xenial+1 (cli) 
Copyright (c) 1997-2016 The PHP Group
Zend Engine v2.6.0, Copyright (c) 1998-2016 Zend Technologies
    with Zend OPcache v7.0.6-dev, Copyright (c) 1999-2016, by Zend Technologies
epriestley added a comment.Feb 28 2017, 8:43 PM

More sure than I should be, it seems. But certainly unrelated.

Closed by commit rPHU81494451f9be: Minor fix presumably identified by PHPStan (authored by joshuaspence, committed by joshuaspence). · Explain WhyFeb 28 2017, 8:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
parser/
xhpast/
api/
4 lines

Diff 41922

View Options

src/parser/xhpast/api/XHPASTNode.php

Loading...
Phabricator · Built by Phacility