Minor fix presumably identified by PHPStan
ClosedPublic
Actions

Authored by joshuaspence on Feb 28 2017, 8:41 PM.

Tags

None

Referenced Files

	F15415090: D17435.id41923.diff
	Thu, Mar 20, 3:56 AM

	F15388118: D17435.diff
	Sat, Mar 15, 3:20 AM

	F15291615: D17435.diff
	Wed, Mar 5, 12:56 AM

	Unknown Object (File)
	Fri, Feb 28, 12:46 AM

	Unknown Object (File)
	Fri, Feb 21, 3:13 PM

	Unknown Object (File)
	Fri, Feb 21, 10:52 AM

	Unknown Object (File)
	Feb 19 2025, 3:16 PM

	Unknown Object (File)
	Feb 16 2025, 12:18 PM

Subscribers

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHU81494451f9be: Minor fix presumably identified by PHPStan

Summary

Address comments from @vrana, see D14512#207302.

Test Plan

Ran unit tests.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence created this revision.Feb 28 2017, 8:41 PM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 28 2017, 8:41 PM

Herald added subscribers: Firehed, Korvin. · View Herald Transcript

Unit test thing is a PHP7 thing.

This revision is now accepted and ready to land.Feb 28 2017, 8:41 PM

In D17435#208504, @epriestley wrote:

Unit test thing is a PHP7 thing.

Are you sure?

> php -v
PHP 5.6.30-1+deb.sury.org~xenial+1 (cli) 
Copyright (c) 1997-2016 The PHP Group
Zend Engine v2.6.0, Copyright (c) 1998-2016 Zend Technologies
    with Zend OPcache v7.0.6-dev, Copyright (c) 1999-2016, by Zend Technologies

More sure than I should be, it seems. But certainly unrelated.

Closed by commit rPHU81494451f9be: Minor fix presumably identified by PHPStan (authored by joshuaspence, committed by joshuaspence). · Explain WhyFeb 28 2017, 8:43 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

xhpast/

api/

XHPASTNode.php

4 lines

Diff 41923

View Options

src/parser/xhpast/api/XHPASTNode.php

Minor fix presumably identified by PHPStanClosedPublicActions