Page MenuHomePhabricator

Minor fix presumably identified by PHPStan
ClosedPublic

Authored by joshuaspence on Feb 28 2017, 8:41 PM.
Tags
None
Referenced Files
F14011714: D17435.diff
Fri, Nov 1, 5:10 AM
F14005491: D17435.diff
Sun, Oct 27, 1:58 PM
F13978784: D17435.diff
Sat, Oct 19, 12:57 AM
F13972411: D17435.id.diff
Thu, Oct 17, 6:50 PM
Unknown Object (File)
Oct 2 2024, 7:17 AM
Unknown Object (File)
Sep 18 2024, 1:39 PM
Unknown Object (File)
Aug 24 2024, 4:44 PM
Unknown Object (File)
Aug 23 2024, 8:00 PM

Details

Summary

Address comments from @vrana, see D14512#207302.

Test Plan

Ran unit tests.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Unit test thing is a PHP7 thing.

This revision is now accepted and ready to land.Feb 28 2017, 8:41 PM

Unit test thing is a PHP7 thing.

Are you sure?

> php -v
PHP 5.6.30-1+deb.sury.org~xenial+1 (cli) 
Copyright (c) 1997-2016 The PHP Group
Zend Engine v2.6.0, Copyright (c) 1998-2016 Zend Technologies
    with Zend OPcache v7.0.6-dev, Copyright (c) 1999-2016, by Zend Technologies

More sure than I should be, it seems. But certainly unrelated.

This revision was automatically updated to reflect the committed changes.