Fixes T12243. That error occured due to network flakiness with some mounted filesystems so I'm not sure how best to simulate it. But you can look and see that the PhutilProxyException does indeed expect an exception as its second arg.
Details
Details
- Reviewers
epriestley yelirekim - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T12243: Repository cluster engine throws InvalidArgument exception when failing to acquire a write lock
- Commits
- rPe0675b28d8e6: Pass exception to PhutilProxyException
Look at method signature... look at callsite... now back at the method. Smile and nod.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- PassExceptionToProxyMethod (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 15588 Build 20569: Run Core Tests Build 20568: arc lint + arc unit