Ref T12174. This could be a little more verbose.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T12174: Home Menu Errata
- Commits
- rP67d9568fb5a9: Add better description to built-in Home
Review Global Menu Items
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- home-description (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 15495 Build 20426: Run Core Tests Build 20425: arc lint + arc unit
Event Timeline
Comment Actions
Is /mail/ instructive? I see this from the CLI:
! chad (Chad Little)
- Mail Tags: This mail has tags which control which users receive it, and this recipient has not elected to receive mail with any of the tags on this message (Settings > Email Preferences).
Do you have "other activity not listed above" set to not email you?
Comment Actions
If you previously got mail for just "Accept" I'd say that was a bug, since it isn't any of the actions listed in the other categories. I don't think this behavior has changed, though?
Comment Actions
Can you view raw headers on one of them and show me the value of X-Phabricator-Mail-Tags?
Comment Actions
Did the one with <differential-reviewers> have a corresponding reviewer change (e.g., maybe the accepting reviewer wasn't previously a reviewer)?
Did the one with <differential-comment> have a comment or an inline comment?
Comment Actions
Maybe blessed reviewers group changed?
I don't think so: the last change looks like it was in September, 2015 when btrahan was removed:
https://secure.phabricator.com/project/manage/1308/#7711
Was I always a reviewer?
If you want to give me the revision number, I can look at the transaction log.
Comment Actions
X-Phabricator-Mail-Tags: <differential-other>, <differential-reviewers> Thread-Topic: D17101: Minor style updates to Phame X-Herald-Rules: <7>, <11>, <17>, <49>, <106>, <78>, <86> X-Phabricator-To: <PHID-USER-nbueerxdfl6csylnv6oe> X-Phabricator-To: <PHID-USER-ba8aeea1b3fe2853d6bb> X-Phabricator-Cc: <PHID-USER-jussrd5uxlujpdb2xgde>
Comment Actions
Here's the full transaction log for D17101:
mysql> select * from differential_transaction where objectPHID = 'PHID-DREV-aglksdk4lz44kj2dxzgg'\G
*************************** 1. row ***************************
id: 202763
phid: PHID-XACT-DREV-tac6uuhcvxvlrwy
authorPHID: PHID-USER-nbueerxdfl6csylnv6oe
objectPHID: PHID-DREV-aglksdk4lz44kj2dxzgg
viewPolicy: public
editPolicy: PHID-USER-nbueerxdfl6csylnv6oe
commentPHID: NULL
commentVersion: 0
transactionType: core:create
oldValue: null
newValue: null
contentSource: {"source":"conduit","params":[]}
metadata: {"core.create":true}
dateCreated: 1482383401
dateModified: 1482383401
*************************** 2. row ***************************
id: 202764
phid: PHID-XACT-DREV-6swbbgtdjank43x
authorPHID: PHID-USER-nbueerxdfl6csylnv6oe
objectPHID: PHID-DREV-aglksdk4lz44kj2dxzgg
viewPolicy: public
editPolicy: PHID-USER-nbueerxdfl6csylnv6oe
commentPHID: NULL
commentVersion: 0
transactionType: differential:update
oldValue: null
newValue: "PHID-DIFF-fcv3lkqschqjyvxqmotm"
contentSource: {"source":"conduit","params":[]}
metadata: {"core.create":true}
dateCreated: 1482383401
dateModified: 1482383401
*************************** 3. row ***************************
id: 202765
phid: PHID-XACT-DREV-oee7wffyo2zzmm3
authorPHID: PHID-USER-nbueerxdfl6csylnv6oe
objectPHID: PHID-DREV-aglksdk4lz44kj2dxzgg
viewPolicy: public
editPolicy: PHID-USER-nbueerxdfl6csylnv6oe
commentPHID: NULL
commentVersion: 0
transactionType: differential.revision.title
oldValue: ""
newValue: "Minor style updates to Phame"
contentSource: {"source":"conduit","params":[]}
metadata: {"core.create":true}
dateCreated: 1482383401
dateModified: 1482383401
*************************** 4. row ***************************
id: 202766
phid: PHID-XACT-DREV-6czokaecxvg65y4
authorPHID: PHID-USER-nbueerxdfl6csylnv6oe
objectPHID: PHID-DREV-aglksdk4lz44kj2dxzgg
viewPolicy: public
editPolicy: PHID-USER-nbueerxdfl6csylnv6oe
commentPHID: NULL
commentVersion: 0
transactionType: differential.revision.summary
oldValue: ""
newValue: "More obvious crumbs, remove border on images, better image spacing."
contentSource: {"source":"conduit","params":[]}
metadata: {"core.create":true}
dateCreated: 1482383401
dateModified: 1482383401
*************************** 5. row ***************************
id: 202767
phid: PHID-XACT-DREV-kkxf2rifuewt5ir
authorPHID: PHID-USER-nbueerxdfl6csylnv6oe
objectPHID: PHID-DREV-aglksdk4lz44kj2dxzgg
viewPolicy: public
editPolicy: PHID-USER-nbueerxdfl6csylnv6oe
commentPHID: NULL
commentVersion: 0
transactionType: differential.revision.testplan
oldValue: ""
newValue: "Build out a test blog, click on crumbs, view spacing."
contentSource: {"source":"conduit","params":[]}
metadata: {"core.create":true}
dateCreated: 1482383401
dateModified: 1482383401
*************************** 6. row ***************************
id: 202768
phid: PHID-XACT-DREV-3kowmezh6zzqvqc
authorPHID: PHID-USER-nbueerxdfl6csylnv6oe
objectPHID: PHID-DREV-aglksdk4lz44kj2dxzgg
viewPolicy: public
editPolicy: PHID-USER-nbueerxdfl6csylnv6oe
commentPHID: NULL
commentVersion: 0
transactionType: differential.revision.reviewers
oldValue: []
newValue: {"PHID-USER-ba8aeea1b3fe2853d6bb":"added"}
contentSource: {"source":"conduit","params":[]}
metadata: {"core.create":true}
dateCreated: 1482383401
dateModified: 1482383401
*************************** 7. row ***************************
id: 202769
phid: PHID-XACT-DREV-v7vkkmo4uutuemq
authorPHID: PHID-APPS-PhabricatorHeraldApplication
objectPHID: PHID-DREV-aglksdk4lz44kj2dxzgg
viewPolicy: public
editPolicy: no-one
commentPHID: NULL
commentVersion: 0
transactionType: core:subscribers
oldValue: []
newValue: ["PHID-USER-jussrd5uxlujpdb2xgde"]
contentSource: {"source":"herald","params":[]}
metadata: {"herald:transcriptID":188987}
dateCreated: 1482383401
dateModified: 1482383401
*************************** 8. row ***************************
id: 202770
phid: PHID-XACT-DREV-vfvkvioj5jtf47e
authorPHID: PHID-USER-ba8aeea1b3fe2853d6bb
objectPHID: PHID-DREV-aglksdk4lz44kj2dxzgg
viewPolicy: public
editPolicy: PHID-USER-ba8aeea1b3fe2853d6bb
commentPHID: NULL
commentVersion: 0
transactionType: differential:action
oldValue: null
newValue: "accept"
contentSource: {"source":"web","params":[]}
metadata: []
dateCreated: 1482411976
dateModified: 1482411976
*************************** 9. row ***************************
id: 202771
phid: PHID-XACT-DREV-f4ycg44cih7recr
authorPHID: PHID-USER-ba8aeea1b3fe2853d6bb
objectPHID: PHID-DREV-aglksdk4lz44kj2dxzgg
viewPolicy: public
editPolicy: PHID-USER-ba8aeea1b3fe2853d6bb
commentPHID: NULL
commentVersion: 0
transactionType: core:edge
oldValue: {"PHID-USER-ba8aeea1b3fe2853d6bb":{"src":"PHID-DREV-aglksdk4lz44kj2dxzgg","type":"35","dst":"PHID-USER-ba8aeea1b3fe2853d6bb","dateCreated":"1482383401","seq":"0","dataID":"46558","data":{"status":"added","diffID":null}}}
newValue: {"PHID-USER-ba8aeea1b3fe2853d6bb":{"data":{"status":"accepted"},"dst":"PHID-USER-ba8aeea1b3fe2853d6bb","type":35}}
contentSource: {"source":"web","params":[]}
metadata: {"edge:type":35}
dateCreated: 1482411976
dateModified: 1482411976
*************************** 10. row ***************************
id: 202772
phid: PHID-XACT-DREV-wy4dgro2vyjnfqg
authorPHID: PHID-USER-ba8aeea1b3fe2853d6bb
objectPHID: PHID-DREV-aglksdk4lz44kj2dxzgg
viewPolicy: public
editPolicy: PHID-USER-ba8aeea1b3fe2853d6bb
commentPHID: NULL
commentVersion: 0
transactionType: differential:status
oldValue: "0"
newValue: 2
contentSource: {"source":"web","params":[]}
metadata: []
dateCreated: 1482411976
dateModified: 1482411976
*************************** 11. row ***************************
id: 202773
phid: PHID-XACT-DREV-3wnbg5w445vqwgu
authorPHID: PHID-USER-nbueerxdfl6csylnv6oe
objectPHID: PHID-DREV-aglksdk4lz44kj2dxzgg
viewPolicy: public
editPolicy: no-one
commentPHID: NULL
commentVersion: 0
transactionType: differential:update
oldValue: "PHID-DIFF-fcv3lkqschqjyvxqmotm"
newValue: "PHID-DIFF-olbbq2l6wvucuubkrj7m"
contentSource: {"source":"daemon","params":[]}
metadata: {"isCommitUpdate":true}
dateCreated: 1482444065
dateModified: 1482444065
*************************** 12. row ***************************
id: 202774
phid: PHID-XACT-DREV-ai2m2qs5ai3nlmf
authorPHID: PHID-USER-nbueerxdfl6csylnv6oe
objectPHID: PHID-DREV-aglksdk4lz44kj2dxzgg
viewPolicy: public
editPolicy: no-one
commentPHID: NULL
commentVersion: 0
transactionType: differential:action
oldValue: null
newValue: "commit"
contentSource: {"source":"daemon","params":[]}
metadata: {"isCommitClose":true,"commitPHID":"PHID-CMIT-ybielbhrvvujyr2wmtd3","committerPHID":"PHID-USER-nbueerxdfl6csylnv6oe","committerName":"chad <autocommitter@example.com>","authorPHID":"PHID-USER-nbueerxdfl6csylnv6oe","authorName":"Chad Little <chad@phacility.com>","revisionMatchData":{"usedURI":true,"foundURI":17101,"validDomain":"https:\/\/secure.phabricator.com","matchHashType":null,"matchHashValue":null}}
dateCreated: 1482444065
dateModified: 1482444065
*************************** 13. row ***************************
id: 206102
phid: PHID-XACT-DREV-3rw77h6gpbyhotl
authorPHID: PHID-USER-nbueerxdfl6csylnv6oe
objectPHID: PHID-DREV-aglksdk4lz44kj2dxzgg
viewPolicy: public
editPolicy: PHID-USER-nbueerxdfl6csylnv6oe
commentPHID: NULL
commentVersion: 0
transactionType: core:edge
oldValue: []
newValue: {"PHID-DREV-r4nixuasqsetuzv4bf47":{"dst":"PHID-DREV-r4nixuasqsetuzv4bf47","type":51,"data":[]}}
contentSource: {"source":"web","params":[]}
metadata: {"edge:type":51}
dateCreated: 1485999329
dateModified: 1485999329
13 rows in set (0.00 sec)I think this is the relevant piece:
*************************** 9. row ***************************
id: 202771
phid: PHID-XACT-DREV-f4ycg44cih7recr
authorPHID: PHID-USER-ba8aeea1b3fe2853d6bb
objectPHID: PHID-DREV-aglksdk4lz44kj2dxzgg
viewPolicy: public
editPolicy: PHID-USER-ba8aeea1b3fe2853d6bb
commentPHID: NULL
commentVersion: 0
transactionType: core:edge
oldValue: {"PHID-USER-ba8aeea1b3fe2853d6bb":{"src":"PHID-DREV-aglksdk4lz44kj2dxzgg","type":"35","dst":"PHID-USER-ba8aeea1b3fe2853d6bb","dateCreated":"1482383401","seq":"0","dataID":"46558","data":{"status":"added","diffID":null}}}
newValue: {"PHID-USER-ba8aeea1b3fe2853d6bb":{"data":{"status":"accepted"},"dst":"PHID-USER-ba8aeea1b3fe2853d6bb","type":35}}
contentSource: {"source":"web","params":[]}
metadata: {"edge:type":35}
dateCreated: 1482411976
dateModified: 1482411976That transaction is changing my reviewer state from "added" to "accepted". If we rendered it, it would read something like "epriestley changed reviewer state for reviewers: epriestley is now 'Accepted'." It does not appear in the transaction log or email because it is redundant with the "epriestley accepted this revision." transaction. After T11114, it no longer generates, because this state change is now a side effect of the "accept" action. However, this transaction would previously trigger a <differential-reviwers> mailtag. I think that was a bug: accepting a revision is pretty definitely not "A revision's reviewers change." to me.