Page MenuHomePhabricator

Allow "Magic Home" to be hidden
ClosedPublic

Authored by epriestley on Feb 1 2017, 6:01 PM.
Tags
None
Referenced Files
F18845508: D17289.id41591.diff
Wed, Oct 29, 12:35 PM
F18830202: D17289.diff
Sat, Oct 25, 4:59 AM
F18776659: D17289.id.diff
Oct 10 2025, 10:49 PM
F18705745: D17289.diff
Sep 28 2025, 12:54 PM
F18638702: D17289.id41588.diff
Sep 17 2025, 11:22 AM
F18624533: D17289.diff
Sep 15 2025, 8:22 PM
F18530094: D17289.diff
Sep 7 2025, 12:41 AM
F18380597: D17289.id.diff
Aug 28 2025, 6:01 PM
Subscribers
None

Details

Summary

Ref T12174. Fallback behavior on this already appears to be sensible.

Test Plan
  • Hid "Magic Home".
  • Viewed homepage with no dashboards on the menu.
  • Saw "Magic Home" content, with no item in the menu selected, which seems reasonable.

Screen Shot 2017-02-01 at 10.00.50 AM.png (780×1 px, 172 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I can clean the UX up from here. I thought this would have been more difficult.

This revision is now accepted and ready to land.Feb 1 2017, 6:02 PM

Yeah, I'm a little surprised the fallback already works since I also expected it to be a little more involved. Possible that it only appears to work and will need a little more effort, but should be easy to fix if that's true.

This revision was automatically updated to reflect the committed changes.