Page MenuHomePhabricator

Allow "Magic Home" to be hidden
ClosedPublic

Authored by epriestley on Feb 1 2017, 6:01 PM.
Tags
None
Referenced Files
F19618533: D17289.id.diff
Wed, Feb 4, 8:27 AM
F19554536: D17289.id41591.diff
Thu, Jan 29, 11:13 PM
F19468518: D17289.diff
Jan 4 2026, 5:34 AM
F19303953: D17289.id41588.diff
Dec 24 2025, 6:30 AM
F19244476: D17289.diff
Dec 22 2025, 1:01 AM
F19154481: D17289.id41591.diff
Dec 11 2025, 3:35 PM
F19152310: D17289.id41591.diff
Dec 11 2025, 2:02 AM
F19049743: D17289.id.diff
Nov 27 2025, 6:15 PM
Subscribers
None

Details

Summary

Ref T12174. Fallback behavior on this already appears to be sensible.

Test Plan
  • Hid "Magic Home".
  • Viewed homepage with no dashboards on the menu.
  • Saw "Magic Home" content, with no item in the menu selected, which seems reasonable.

Screen Shot 2017-02-01 at 10.00.50 AM.png (780×1 px, 172 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I can clean the UX up from here. I thought this would have been more difficult.

This revision is now accepted and ready to land.Feb 1 2017, 6:02 PM

Yeah, I'm a little surprised the fallback already works since I also expected it to be a little more involved. Possible that it only appears to work and will need a little more effort, but should be easy to fix if that's true.

This revision was automatically updated to reflect the committed changes.