Allow "Magic Home" to be hidden
ClosedPublic

Authored by epriestley on Feb 1 2017, 6:01 PM.

Details

Summary

Ref T12174. Fallback behavior on this already appears to be sensible.

Test Plan
  • Hid "Magic Home".
  • Viewed homepage with no dashboards on the menu.
  • Saw "Magic Home" content, with no item in the menu selected, which seems reasonable.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
epriestley created this revision.Feb 1 2017, 6:01 PM
β€’ chad accepted this revision.Feb 1 2017, 6:02 PM

I can clean the UX up from here. I thought this would have been more difficult.

This revision is now accepted and ready to land.Feb 1 2017, 6:02 PM

Yeah, I'm a little surprised the fallback already works since I also expected it to be a little more involved. Possible that it only appears to work and will need a little more effort, but should be easy to fix if that's true.

This revision was automatically updated to reflect the committed changes.