Page MenuHomePhabricator

Allow "Magic Home" to be hidden
ClosedPublic

Authored by epriestley on Feb 1 2017, 6:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 23, 5:05 AM
Unknown Object (File)
Fri, Mar 15, 11:42 AM
Unknown Object (File)
Fri, Mar 15, 7:07 AM
Unknown Object (File)
Mon, Mar 4, 2:43 AM
Unknown Object (File)
Mon, Mar 4, 2:43 AM
Unknown Object (File)
Mon, Mar 4, 2:42 AM
Unknown Object (File)
Feb 25 2024, 2:22 PM
Unknown Object (File)
Feb 3 2024, 2:24 PM
Subscribers
None

Details

Summary

Ref T12174. Fallback behavior on this already appears to be sensible.

Test Plan
  • Hid "Magic Home".
  • Viewed homepage with no dashboards on the menu.
  • Saw "Magic Home" content, with no item in the menu selected, which seems reasonable.

Screen Shot 2017-02-01 at 10.00.50 AM.png (780×1 px, 172 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I can clean the UX up from here. I thought this would have been more difficult.

This revision is now accepted and ready to land.Feb 1 2017, 6:02 PM

Yeah, I'm a little surprised the fallback already works since I also expected it to be a little more involved. Possible that it only appears to work and will need a little more effort, but should be easy to fix if that's true.

This revision was automatically updated to reflect the committed changes.