Differential D17289

Allow "Magic Home" to be hidden
ClosedPublic
Actions

Authored by epriestley on Feb 1 2017, 6:01 PM.

Details

Reviewers

chad

Maniphest Tasks

T12174: Home Menu Errata

Commits

rP6abdae8e7396: Allow "Magic Home" to be hidden

Summary

Ref T12174. Fallback behavior on this already appears to be sensible.

Test Plan

Hid "Magic Home".
Viewed homepage with no dashboards on the menu.
Saw "Magic Home" content, with no item in the menu selected, which seems reasonable.

Screen Shot 2017-02-01 at 10.00.50 AM.png (780×1 px, 172 KB)

Diff Detail

Repository

rP Phabricator

Branch

home2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15486
Build 20412: Run Core Tests
Build 20411: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 1 2017, 6:01 PM

Oh haha

🐈

Harbormaster completed remote builds in B15486: Diff 41588.Feb 1 2017, 6:02 PM

I can clean the UX up from here. I thought this would have been more difficult.

This revision is now accepted and ready to land.Feb 1 2017, 6:02 PM

Yeah, I'm a little surprised the fallback already works since I also expected it to be a little more involved. Possible that it only appears to work and will need a little more effort, but should be easy to fix if that's true.

Closed by commit rP6abdae8e7396: Allow "Magic Home" to be hidden (authored by epriestley, committed by epriestley). · Explain WhyFeb 1 2017, 6:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

home/

menuitem/

PhabricatorHomeProfileMenuItem.php

5 lines

Diff 41588

View Options

src/applications/home/menuitem/PhabricatorHomeProfileMenuItem.php

Allow "Magic Home" to be hiddenClosedPublicActions