Page MenuHomePhabricator

Navigage Buildkite builds with more nuance
ClosedPublic

Authored by epriestley on Jan 31 2017, 11:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 6, 11:01 AM
Unknown Object (File)
Mon, Mar 6, 8:49 AM
Unknown Object (File)
Feb 25 2023, 12:52 PM
Unknown Object (File)
Feb 19 2023, 7:12 AM
Unknown Object (File)
Feb 19 2023, 5:28 AM
Unknown Object (File)
Feb 18 2023, 2:41 AM
Unknown Object (File)
Feb 17 2023, 11:35 AM
Unknown Object (File)
Jan 10 2023, 10:36 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T12173.

  • If we want to fetch a tag, Buildkite needs it as a "branch" (this means more like "ref to fetch").
  • The API gets upset if we pass "refs/tags/...", so just pass the tag name without the prefix, which works.
  • Do a better job with commits and pass a real branch to fetch.
Test Plan
  • Built a commit with Buildkite.
  • Build a revision with Buildkite.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable