Navigage Buildkite builds with more nuance

Authored by epriestley on Jan 31 2017, 11:34 PM.



Ref T12173.

  • If we want to fetch a tag, Buildkite needs it as a "branch" (this means more like "ref to fetch").
  • The API gets upset if we pass "refs/tags/...", so just pass the tag name without the prefix, which works.
  • Do a better job with commits and pass a real branch to fetch.
Test Plan
  • Built a commit with Buildkite.
  • Build a revision with Buildkite.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
Owners added a subscriber: Restricted Owners Package.Jan 31 2017, 11:34 PM
  • 2016 in 2017? LUL
  • Add additional information about the tag behavior.
chad accepted this revision.Feb 1 2017, 12:58 AM
This revision is now accepted and ready to land.Feb 1 2017, 12:58 AM
This revision was automatically updated to reflect the committed changes.