Page MenuHomePhabricator

Navigage Buildkite builds with more nuance
ClosedPublic

Authored by epriestley on Jan 31 2017, 11:34 PM.
Tags
None
Referenced Files
F18899482: D17282.diff
Fri, Nov 7, 7:53 PM
F18834230: D17282.id.diff
Oct 26 2025, 7:24 AM
F18832972: D17282.diff
Oct 26 2025, 12:02 AM
F18820450: D17282.id41576.diff
Oct 22 2025, 3:10 PM
F18782046: D17282.id41575.diff
Oct 13 2025, 12:26 AM
F18777104: D17282.id41574.diff
Oct 11 2025, 12:55 AM
F18757054: D17282.id.diff
Oct 5 2025, 3:21 PM
F18713385: D17282.diff
Sep 29 2025, 6:16 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T12173.

  • If we want to fetch a tag, Buildkite needs it as a "branch" (this means more like "ref to fetch").
  • The API gets upset if we pass "refs/tags/...", so just pass the tag name without the prefix, which works.
  • Do a better job with commits and pass a real branch to fetch.
Test Plan
  • Built a commit with Buildkite.
  • Build a revision with Buildkite.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable